Project

General

Profile

Actions

Bug #14009

closed

Activity filters for groups and people on homepage not working

Added by Sonja Leix about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Home Page
Target version:
Start date:
2021-02-18
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

The filters on the activity feeds for groups and people on the current homepage are not working for me. The wheels are spinning, but the activity feed doesn't change. Anyone else seeing this issue? Not sure if this is a priority to fix given we're redesigning the homepage, but thought I'd flag it.

Actions #1

Updated by Boone Gorges about 3 years ago

  • Category name set to Home Page
  • Assignee set to Raymond Hoh
  • Target version set to 1.18.5

Thanks for the report, Sonja.

I did some quick debugging. The AJAX request was returning a 403 Forbidden error. I traced this to a

check_admin_referer()
failure in BP's AJAX callbacks. The _wpnonce value was being sent as part of the POST payload, so I figured it must be the wrong value, and I had a hunch it might be that the nonce was being generated for one user, then the _wpnonce element was being cached as part of the bp-widget-cache HTML cache, and then served to other users. I deactivated the bp-widget-cached plugin and the requests now work, which supports my hypothesis, though I didn't spend any more time looking into it.

Ray, can you have a look? If there's an easy way to put the nonce outside the cached value, so as to ensure that it is regenerated on each pageload, it should solve the problem.

Actions #2

Updated by Raymond Hoh about 3 years ago

  • Status changed from New to Staged for Production Release

Good catch, Sonja!

Boone is absolutely correct. I've addressed this in https://github.com/cuny-academic-commons/cac/commit/1aaa6c463499f5d2737a7c42d284332198a1aad7 by replacing the cached nonces with the correct nonce at run-time for the widget cache.

Actions #3

Updated by Sonja Leix about 3 years ago

Thanks for the quick troubleshooting and fix! Works again on my end too.

Actions #4

Updated by Raymond Hoh about 3 years ago

The fix is actually scheduled to be released next Tuesday, but should work once the plugin is reactivated.

Actions #5

Updated by Boone Gorges about 3 years ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF