Project

General

Profile

Bug #14228

JITP Not Fully Loading

Added by Luke Waltzer 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
-
Target version:
Start date:
2021-03-24
Due date:
% Done:

0%

Estimated time:

Description

JITP http://jitp.commons.gc.cuny.edu is not fully loading. Seeing this on the staging site as well http://jitpstaging.commons.gc.cuny.edu/.

Adding Patrick DeDauw, who reports that site was working fine earlier this morning, and that no recent changes have been made to the site.

Screenshot_2021-03-24_16-09-41.png (192 KB) Screenshot_2021-03-24_16-09-41.png Boone Gorges, 2021-03-24 12:12 PM

Related issues

Related to CUNY Academic Commons - Bug #13353: jQuery update strategyResolved2020-09-21

History

#1 Updated by Boone Gorges 8 months ago

  • Related to Bug #13353: jQuery update strategy added

#2 Updated by Boone Gorges 8 months ago

  • Target version set to 1.18.8

Some aspects of the site are not compatible with jQuery 3.x (introduced yesterday) and for some reason our automated tools for version fallback didn't work.

I've attached a screenshot showing the errors. I'll take a look at them. For the moment, I've forced the site to use the older jQuery and it is loading normally.

#4 Updated by Raymond Hoh 8 months ago

  • Target version deleted (1.18.8)

Looks like the enable-jquery-migrate-helper plugin is at fault here: https://github.com/WordPress/jquery-migrate-helper/issues/29

#5 Updated by Boone Gorges 8 months ago

Thanks, Ray. I tried patching enable-jquery-migrate-helper but it didn't seem to work (where "work" means "send the AJAX request to downgrade jQuery"). I know that the plugin is working more broadly, as I've gotten five downgrade notices in the last 24 hours from other Commons sites.

#6 Updated by Luke Waltzer 8 months ago

thank you both for such a quick response!

#7 Updated by Boone Gorges 8 months ago

  • Status changed from New to Resolved
  • Target version set to Not tracked

Looking more closely, it appears that there are a couple of jQuery 3 incompatibilities bieng triggered by two plugins: dynamic-content-gallery-plugin and iw-framework-plugin. The former has not been updated in 8 years. The latter was added as a requirement for the Roma theme, so is used only by JITP, and it also has not been updated since being added in 2015.

For the time being, we should keep legacy jQuery in place for this site.

In the longer run, it seems to me that we should either update Roma and its related plugins (#13450) or, if JITP is still active looking to move to a new theme, do nothing and assume that the new theme will not have such problems. On that assumption, I'm going to mark this ticket Resolved.

#8 Updated by Luke Waltzer 8 months ago

JITP is actively preparing migration to another theme, aiming for summer 2021.

#9 Updated by Boone Gorges 8 months ago

Great, thanks for confirming, Luke.

#10 Updated by Luke Waltzer 8 months ago

Hi Boone-- possible to apply same fix to https://jitpstaging.commons.gc.cuny.edu/? Non-emergency; that site will be active again in a month or so.

#11 Updated by Boone Gorges 8 months ago

Sure thing. I've made the change.

Also available in: Atom PDF