Bug #16198
closedChange role to . .
0%
Description
A user brought to my attention that "Change role to . . " on her site didn't work. Because I know this user and was in a rush, I went ahead as a super admin and made the change for her (ticket 7145 " upgrade a user (Hannah Miller) from Author to Administrator" - https://cunycommons.zendesk.com/agent/tickets/7145)
Now I have another user with the same problem. I had him add me (non super) as an Admin, and I see exactly what he means. When I am logged in as mweber here - https://jjayoersummer.commons.gc.cuny.edu/wp-admin/users.php - and I select a user then try to change their role, simply nothing happens. There is no error message, but the user I am trying to downgrade (jennifereconomos) remains as an admin.
LMK what more info you need. It's ticket 7180, if that helps - https://cunycommons.zendesk.com/agent/tickets/7180
Updated by Boone Gorges over 2 years ago
- Status changed from New to Staged for Production Release
- Assignee set to Boone Gorges
- Target version set to 2.0.1
Thanks for the report. I was able to track down the issue, which is due to a conflict in cac-onboarding. That plugin, which powers the 'Send Invites' tool, hooks into the group- and site-join process, so that it can process group/site invitations. Eg, when you invite Joe to join the Commons and become an Author on your site Foo, we run a routine after Joe joins the Commons to ensure that (a) Joe is a member of Foo, and (b) Joe has the role of Author on Foo. The WP action that we hook into for this is run both on the initial site join as well as when the role of an existing member is changed. In this case, the user was being successfully demoted to Author; but the cac-onboarding routine was running immediately afterward, and recognizing that this user was originally invited to the site with role Administrator, and thus was being (re-)granted that role.
Anyway, the solution is that the cac-onboarding routine should only pull up pending invitations. This ensures that users get the proper role when first accepting an invite, but that future role changes aren't overwritten. See https://github.com/cuny-academic-commons/cac-onboarding/commit/27b6b1d89d8ab9dad581775347be3b831e8bdd43
This change will be part of the 2.0.1 release. In the meantime, I've manually demoted the user in question.
Updated by Boone Gorges over 2 years ago
Maintenance releases are on the second and fourth Tuesdays of the month. This means that 2.0.1 is scheduled for June 14. See https://dev.commons.gc.cuny.edu/release-schedule-and-procedures/
Updated by Boone Gorges over 2 years ago
- Status changed from Staged for Production Release to Resolved