Project

General

Profile

Actions
Copy link

Bug #16656

closed

jQuery migrate helper can cause debug loops

Added by Boone Gorges over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
WordPress Plugins
Target version:
2.0.7
Start date:
2022-08-24
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I noticed when debugging #16655 that the front-end scripts for enable-jquery-migrate-helper were causing an infinite series of log statements. In this particular case, the errors are being triggered by the events-manager plugin upgrade from 5.12.1 to 6.0.1, but the infinite loop seems to be a bug in the enable-jquery-migrate-helper plugin.

Actions
Copy link
 #1

Updated by Boone Gorges over 1 year ago

  • Status changed from New to Resolved

In https://github.com/cuny-academic-commons/cac/commit/d6ada419fe7806d0652697df20bd3215a60af3bd I've added a clause to the enable-jquery-migrate-helper plugin that ensures that infinite log messages aren't written.

To be clear, I think that this points to a bug in events-manager, which will probably cause memory leakage and poor page performance. I don't have the bandwidth to do deeper debugging on that plugin at the moment. But at least my fix should eliminate the significant overhead that was resulting from the error logging.

Actions
Copy link
 #2

Updated by Raymond Hoh over 1 year ago

To be clear, I think that this points to a bug in events-manager, which will probably cause memory leakage and poor page performance.

I took a look over on the wp.org forum for events-manager and a lot of people are complaining about performance issues in v6. For example, https://wordpress.org/support/topic/big-performance-issue-with-6-0-update/.

Also the changelog notes that v6.1 will have a "major architecture change for how tickets are stored" (their words), so we might have to look out for that when we bump Events Manager to v6.1.x and above.

Actions
Copy link

Also available in: Atom PDF