Project

General

Profile

Actions

Bug #16690

closed

Better handling of forum attachments during Library cloning

Added by Boone Gorges over 1 year ago. Updated 10 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group cloning
Target version:
Start date:
2022-08-30
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

When cloning a group, the items in that group's library items are also cloned. See https://github.com/cuny-academic-commons/cac/blob/4b9a461bc56426be3fe44fab6320ae67eb5ca603/wp-content/plugins/bp-custom.php#L1682

The library-cloning script handles three cases: 'bp_group_document', 'bp_doc', and the default case. The default case was meant to handle 'external_link'. But this doesn't properly anticipate the existence of 'forum_attachment', which should have special handling.

As noted in https://redmine.gc.cuny.edu/issues/16673#note-3, the current behavior is incorrect (see https://redmine.gc.cuny.edu/attachments/23102):

Actually, one note -- the three files listed at the bottom of the library (see screenshot) are, I believe, forum attachments. I wanted to delete them, so I clicked "edit," but that brought me to the posts in their original groups. Is there any way you can manually delete them for me? And maybe this is something to address in the cloning process?

Looking back at our notes, we decided not to copy over forum content at all. See https://redmine.gc.cuny.edu/issues/13198#note-7. So we should be skipping 'forum_attachment' items when cloning a library.


Related issues

Related to CUNY Academic Commons - Support #16673: Cloning requestResolvedBoone Gorges2022-08-28

Actions
Actions #1

Updated by Boone Gorges over 1 year ago

Actions #2

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.7 to 2.0.8
Actions #3

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.8 to 2.0.9
Actions #4

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.9 to 2.0.10
Actions #5

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.10 to 2.0.11
Actions #6

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.11 to 2.0.12
Actions #7

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.0.12 to 2.0.13
Actions #8

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.0.13 to 2.0.14
Actions #9

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.0.14 to 2.0.15
Actions #10

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.0.15 to 2.1.1
Actions #11

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.1.1 to 2.1.2
Actions #12

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.1.2 to 2.1.3
Actions #13

Updated by Boone Gorges 11 months ago

  • Target version changed from 2.1.3 to 2.1.4
Actions #14

Updated by Boone Gorges 11 months ago

  • Target version changed from 2.1.4 to 2.1.5
Actions #15

Updated by Boone Gorges 11 months ago

  • Status changed from New to Staged for Production Release

I finally got around to doing this! https://github.com/cuny-academic-commons/cac/commit/124b95945e28b86d5160e037d4bfa3bb02a50bd1 forum_attachment items are now skipped during the clone process.

Actions #16

Updated by Matt Gold 11 months ago

thank you!

Actions #17

Updated by Boone Gorges 10 months ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF