Better handling of forum attachments during Library cloning
When cloning a group, the items in that group's library items are also cloned. See https://github.com/cuny-academic-commons/cac/blob/4b9a461bc56426be3fe44fab6320ae67eb5ca603/wp-content/plugins/bp-custom.php#L1682
The library-cloning script handles three cases: 'bp_group_document', 'bp_doc', and the default case. The default case was meant to handle 'external_link'. But this doesn't properly anticipate the existence of 'forum_attachment', which should have special handling.
Actually, one note -- the three files listed at the bottom of the library (see screenshot) are, I believe, forum attachments. I wanted to delete them, so I clicked "edit," but that brought me to the posts in their original groups. Is there any way you can manually delete them for me? And maybe this is something to address in the cloning process?
Looking back at our notes, we decided not to copy over forum content at all. See https://redmine.gc.cuny.edu/issues/13198#note-7. So we should be skipping 'forum_attachment' items when cloning a library.