Project

General

Profile

Actions

Bug #17014

closed

Missing styles on Docs Page?

Added by Sara Cannon about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Design
Target version:
Start date:
2022-10-12
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

When testing out features, I came across the docs page which looks like it might be missing styles. Is this a bug or is the page actually supposed to look like this? (screenshot attached)

https://commons.gc.cuny.edu/docs/my-groups/


Files

Docs Screenshot.jpeg (975 KB) Docs Screenshot.jpeg Sara Cannon, 2022-10-12 01:52 PM
Actions #1

Updated by Boone Gorges about 2 years ago

Hi Sara - Thanks for the ticket and the screenshot.

The Docs feature on the Commons is meant to be accessed only via individual groups, not via the /docs/ URL. I'm not surprised that you are able to access /docs/ (it's never been blocked) but I'm a bit surprised that you were able to navigate there. Do you recall how you did it? I think we not spend time styling it, and instead should ensure that it's removed from navigation, and perhaps protected with a redirect rule.

Actions #2

Updated by Sara Cannon about 2 years ago

Ah! I was able to get to it via creating a document on the profile page. Here are the steps:

1) Navigate to Docs under my profile: https://commons.gc.cuny.edu/members/scannon/docs/ https://share.getcloudapp.com/geuyPZZj
2) Click on "Create A Doc" (goes to https://commons.gc.cuny.edu/docs/create/)
3) The upper navigation has a link to the docs page https://share.getcloudapp.com/E0uZL8P5

Is the "Create A Doc" page supposed to be blocked as well? I believe I only see it when there are no docs created.

Actions #3

Updated by Boone Gorges about 2 years ago

  • Status changed from New to Staged for Production Release
  • Target version set to 2.0.10

Thanks, Sara!

As you suspect, you're not supposed to be able to get to /docs/create. All Doc creation is intended to happen through groups.

For the time being, the lowest-overhead fix is to remove the '...Why not create one?' language from a user's Docs listing. This will close the entry point to /docs/. I've made this change in https://github.com/cuny-academic-commons/cac/commit/86090e725cf91d87b65ae007f5d5ebc6e9c92935 and it will be part of the next release.

Actions #4

Updated by Boone Gorges about 2 years ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF