Bug #17059
closedBroken recursive submodule configuration in mellontheme
0%
Description
The mellontheme repository has its own submodule configuration for this Redux Framework repository. That submodule configuration attempts to load `git://github.com/kaymmm/Redux-Framework/`, which appears to now be an invalid git URL or an invalid GitHub URL.
(I haven't spent much time trying to figure out why, but I am not able to check it out locally and GitHub actions are also unable to, both with timeout errors when trying to connect to `github.com`.)
I forked the theme to a repository under my personal account and updated the submodule URL to git@github.com:kaymmm/Redux-Framework.git. This appears to have done the trick for GitHub actions.
The best course of action seems to be making a change to .gitmodules on the kaymmm/mellontheme repo.
Previously related submodule issues with that repository: https://redmine.gc.cuny.edu/issues/2569
Updated by Boone Gorges over 1 year ago
Thanks for debugging this, Jeremy.
Given that the theme has not been updated on the Commons since at least 2018, and given that the original theme author has moved on to bigger and better things, I wonder if perhaps we should just stop loading it as a submodule. Instead, we'd just include the entire theme - including the Redux-Framework dependency - in the codebase. What do you think of that idea?
Updated by Boone Gorges about 1 year ago
- Status changed from New to Resolved
This was done in 0c2c63a459260dd70a1553d0597d649786e05601