Project

General

Profile

Actions

Bug #17059

open

Broken recursive submodule configuration in mellontheme

Added by Jeremy Felt 4 months ago. Updated 4 months ago.

Status:
New
Priority name:
Normal
Assignee:
-
Category name:
-
Target version:
-
Start date:
2022-10-18
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

The mellontheme repository has its own submodule configuration for this Redux Framework repository. That submodule configuration attempts to load `git://github.com/kaymmm/Redux-Framework/`, which appears to now be an invalid git URL or an invalid GitHub URL.

(I haven't spent much time trying to figure out why, but I am not able to check it out locally and GitHub actions are also unable to, both with timeout errors when trying to connect to `github.com`.)

I forked the theme to a repository under my personal account and updated the submodule URL to :kaymmm/Redux-Framework.git. This appears to have done the trick for GitHub actions.

The best course of action seems to be making a change to .gitmodules on the kaymmm/mellontheme repo.

Previously related submodule issues with that repository: https://redmine.gc.cuny.edu/issues/2569

Actions #1

Updated by Boone Gorges 4 months ago

Thanks for debugging this, Jeremy.

Given that the theme has not been updated on the Commons since at least 2018, and given that the original theme author has moved on to bigger and better things, I wonder if perhaps we should just stop loading it as a submodule. Instead, we'd just include the entire theme - including the Redux-Framework dependency - in the codebase. What do you think of that idea?

Actions

Also available in: Atom PDF