CUNY Academic Commons

This seems like a bug. If a person leaves a group, I believe we should also be removing the user from the groupblog as well.

Boone, I'm just looking into this.

In BP Groupblog, when a user leaves a group and that user has a role on the connected groupblog, BP Groupblog currently downgrades the user's role to 'subscriber' instead of removing the user from the blog outright with remove_user_from_blog(): https://github.com/boonebgorges/bp-groupblog/blob/683c057757cf46de17e958d0d9fb289bcb64e0d7/bp-groupblog.php#L473 . Do you remember why we decided to downgrade the user's role instead of removing the user from the site?

Looks like the decision about this behavior was made before our time on the plugin: https://github.com/boonebgorges/bp-groupblog/commit/a13856abe7092e75f984d0141c16f97d494b83ac#diff-f1ad09172f3fb6ec4cc3c58e5f602bb0b8efd39b9be270e3e615f90ae71e685fR645

I think we can safely change it to remove the user from the blog.

Thanks to you both! This can be closed.

Thanks, Marilyn! I'll wait to close the ticket until we've got the upstream fix in place as well.

Ray, I went to make the change, but I wasn't sure how to handle post-reassigning. Presumably we want to pass 0 (remove_user_from_blog( $user_id, $blog_id, 0 );) so that no reassignment takes place, right?

Presumably we want to pass 0 (remove_user_from_blog( $user_id, $blog_id, 0 );) so that no reassignment takes place, right?

Yes, let's pass 0 as we wouldn't want to reassign posts to another user. This would be important for course sites. Do you want me to send a PR to bp-groupblog or do you want to handle that, Boone?