Project

General

Profile

Actions

Bug #19340

closed

Fatal error due to buddypress-group-email-subscription deployment weirdness

Added by Boone Gorges 12 months ago. Updated 12 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
-
Target version:
Start date:
2023-11-28
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

During the 2.2.3 release, there was a few minutes of downtime due to some oddness in buddypress-group-email-subscription. Here's what was happening:

1. In some previous release, we switched to the bleeding-edge version of BPGES in order to inherit a hotfix for a bug
2. Previous versions of BPGES had the /vendor/ directory ignored in .gitignore, because BPGES only had dev Composer requirements
3. The most recent 4.2.x release of BPGES introduced a polyfill library for BP 12.0 compatibility. The library is autoloaded by Composer.
4. During the release process, BPGES was updated to this latest version. The release version of BPGES does not contain a .gitignore file, which means that the one that we'd synced from a previous bleeding-edge version was left in place. This meant that the now-required /vendor/ directory was not tracked by Git, and was not included in the CAC release. This caused fatal errors on the main site.

I'll follow up in a comment with details of the fix.

Actions

Also available in: Atom PDF