Project

General

Profile

Actions
Copy link

Bug #19436

closed

Doc nav displays twice on a group doc page

Added by Raymond Hoh 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
BuddyPress Docs
Target version:
2.2.5
Start date:
2023-12-18
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Came across a bug while looking into #19415 where the doc nav was displaying directly below the main navigation, but before the main group interface. Here's an example doc on production with this problem: https://commons.gc.cuny.edu/groups/bikecuny/docs/bike-shops/ .

Bug is due to using bp_buffer_template_part() without setting the $echo parameter to false in BuddyPress Docs: https://github.com/buddypress/buddypress/blob/39bba862906314d48eeea11ffc127fc8b8fff8c0/src/bp-core/bp-core-template-loader.php#L401

I've opened a PR for BP Docs here: https://github.com/boonebgorges/buddypress-docs/pull/740.

Boone, can you review when you have the chance?

Actions
Copy link
 #1

Updated by Boone Gorges 4 months ago

As I commented on the GitHub issue, the Docs team is working on a more general fix that will include what you've suggested. But the more general fix doesn't really affect the Commons since we run a legacy theme, so I'm going to go ahead and put this in place as a hotfix on our site.

Actions
Copy link

Also available in: Atom PDF