Project

General

Profile

Actions

Bug #2014

closed

Improper margins on Members Directory

Added by Matt Gold over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Dominic Giglio
Category name:
BuddyPress (misc)
Target version:
Start date:
2012-08-01
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Please see attached screenshot, which shows filter checkbox buttons being cut off on the left side. Happens whether I zoom in or out on the browser.

Mac OS X, Chrome


Files

Actions #1

Updated by Matt Gold over 11 years ago

Forgot to attach screenshot, which is of this page - http://commons.gc.cuny.edu/members/

Actions #2

Updated by Boone Gorges over 11 years ago

Check to make sure that you don't have any user scripts modifying all checkboxes on your machine/browser.

Actions #3

Updated by Matt Gold over 11 years ago

Happy to do that but unsure how to check . . . .

Actions #4

Updated by Matt Gold over 11 years ago

Here are my Chrome extensions:

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.57 Safari/536.11

Extensions: 14
- Google Reader Notifier (by Google) v1.3.1: https://chrome.google.com/webstore/detail/apflmjolhbonpkbkooiamcnenbmbjcbf
- Firebug Lite for Google Chrome™ v1.4.0.11967: https://chrome.google.com/webstore/detail/bmagokdooijbeehmkpknfglimnifench
- Share Extensions v0.0.9: https://chrome.google.com/webstore/detail/chdafcbnfkfenoeejpaeenpdamhmalhe
- Replies and more for Google+ v1.56: https://chrome.google.com/webstore/detail/fgmhgfecnmeljhchgcjlfldjiepcfpea
- History Eraser v3.1: https://chrome.google.com/webstore/detail/gjieilkfnnjoihjjonajndjldjoagffm
- Remember The Milk for Gmail v1.0.2: https://chrome.google.com/webstore/detail/hphjpfmagbhbdfhdndglcccmhdjhjjce
- Zotero Connector v3.0.8.1: https://chrome.google.com/webstore/detail/jciblakmllnhbhjjgkbkeihelcndmgnh
- Boomerang for Gmail v1.0: https://chrome.google.com/webstore/detail/mdkdbdadolokifeomchamhifddohomii
- +Photo Zoom v0.1.0.29: https://chrome.google.com/webstore/detail/njoglkofocgopmdfjnbifnicbickbola
- RSS Subscription Extension (by Google) v2.2.0: https://chrome.google.com/webstore/detail/nlbjncdgjeocebhnmkbbbdekmmmcbfjd
- Readability v1.10: https://chrome.google.com/webstore/detail/oadggleneidfmbhhedlildjnpgcggmch
- Extended Share for Google Plus v3.0: https://chrome.google.com/webstore/detail/oenpjldbckebacipkfbcoppmiflglnib
- OpenAttribute v0.90: https://chrome.google.com/webstore/detail/ohkidpebfeojnggafnkbafjpagnkgjak
- Evernote Web Clipper v5.5.1: https://chrome.google.com/webstore/detail/pioclpoplcdbaefihamjohnefbikjilc

Actions #5

Updated by Boone Gorges over 11 years ago

  • Assignee changed from Boone Gorges to Dominic Giglio
  • Severity set to Trivial

Dom, do you have a Mac with Chrome handy to look at this? Thanks. (See also Matt's screenshot here http://redmine.gc.cuny.edu/issues/120#note-22, which is probably the same issue.)

Actions #6

Updated by Matt Gold over 11 years ago

Trivial? Trivial?!! Well, I never.

Actions #7

Updated by Matt Gold over 11 years ago

Hi Dom,

If you could get to this ASAP, I'd appreciate it, since we're trying to include it in the 1.4 release. Many thanks.

Best,

Matt

Actions #8

Updated by Dominic Giglio over 11 years ago

I'll have something for you on this (and hopefully #120 referenced above) as well as #228 (cookies/login redirect) later today.

Actions #9

Updated by Matt Gold over 11 years ago

Great -- thanks, Dom.

Actions #10

Updated by Dominic Giglio over 11 years ago

Boone,

I cannot reproduce Matt's screenshot on Chrome with my Mac Mini. But I adjusted the padding in bp-nelo's custom.css to give those inputs a little breathing room anyways.

Commit: https://github.com/castiron/cac/commit/1192f506a61e44b0c88f6d5c63ad2bdb3d866e03

Also, I cannot reproduce Matt's screenshot from http://redmine.gc.cuny.edu/issues/120#note-22, from which part of the Commons was that shot taken?

Actions #11

Updated by Boone Gorges over 11 years ago

Sorry, I wasn't a watcher, so I missed these messages.

Trivial? Trivial?!! Well, I never.

If three pixels of hidden radio buttons, not affecting functionality, and apparently only visible on your computer, does not count as trivial, then I'm not sure what does :-D

But I adjusted the padding in bp-nelo's custom.css to give those inputs a little breathing room anyways.

OK. But this is a very specific fix to what is, I assume, a more general issue with the way that Matt's browser renders radio buttons. That said, we've gotta do what we've gotta do.

I cannot reproduce Matt's screenshot from http://redmine.gc.cuny.edu/issues/120#note-22, from which part of the Commons was that shot taken?

From the new Visibility settings in 1.4. You'll have to examine on cdev.

Actions #12

Updated by Matt Gold over 11 years ago

All kidding aside, we should only work on this if it is affecting other users. If others can see what I see, I think we should fix the design flaw. If I really am the only one seeing this, let's put it on hold.

Actions #13

Updated by Boone Gorges over 11 years ago

  • Target version changed from 1.4 to 1.5
Actions #14

Updated by Boone Gorges over 11 years ago

  • Status changed from Assigned to Resolved

Since Dom did add a little breathing room, and since we haven't heard other reports of this issue cropping up, I'm marking Resolved.

Actions #15

Updated by Matt Gold over 11 years ago

Sounds good. Thanks.

Actions

Also available in: Atom PDF