Project

General

Profile

Actions

Bug #20443

closed

Can't vertically scroll 'new topic' modal

Added by Boone Gorges 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Forums
Target version:
Start date:
2024-06-04
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

See attached gif.

I was able to fix locally with the attached patch. I was unsure of the thought behind the min-height media query, so I thought I'd post it here for your review rather than committing directly.


Files

Peek 2024-06-04 12-35.gif (916 KB) Peek 2024-06-04 12-35.gif Boone Gorges, 2024-06-04 01:35 PM
20443.diff (480 Bytes) 20443.diff Boone Gorges, 2024-06-04 01:37 PM
Actions #1

Updated by Boone Gorges 6 months ago

Actions #2

Updated by Raymond Hoh 6 months ago

  • Status changed from New to Testing Required

Thanks for the report, Boone.

I wanted to ensure that the modal didn't have to grow too tall if there wasn't enough content, but that didn't work for those users that had more content than usual. I've fixed this in https://github.com/cuny-academic-commons/cac/commit/ecae0e2a3fc9c13202af25517af528e1a12a6985 . This is available for testing on cdev.

Actions #3

Updated by Boone Gorges 6 months ago

Works perfectly for me. Thanks!

Actions #4

Updated by Boone Gorges 5 months ago

  • Status changed from Testing Required to Resolved
Actions

Also available in: Atom PDF