Project

General

Profile

Actions

Bug #20509

closed

Compatibility with Two Factor v0.9

Added by Raymond Hoh 28 days ago. Updated 28 days ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2024-06-25
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

While working on #20465, I had to test two-factor authentication and found that when we updated the Two Factor plugin to v0.9.1 as part of the v2.3.8 milestone, the Two Factor plugin changed a few things cosmetically and, most notably, added a "Reauthenticate" button if you haven't updated your 2FA settings in awhile. See https://github.com/WordPress/two-factor/pull/529 .

I'm going to commit a few changes so our BuddyPress Two Factor integration is mostly inline and up-to-date with the latest changes.

Actions #1

Updated by Raymond Hoh 28 days ago

  • Status changed from New to Staged for Production Release

In https://github.com/cuny-academic-commons/cac/commit/3fc611c10e8c71729ea72be5c104301ca124d083 , I've done the following:

  • Add spacing for new "Revalidate now" button and hide the two factor options table if the user needs to revalidate their session. For our bp-nelo theme, style button according to our redesign styles.
  • Remove new placement of "Two-Factor Options" admin heading
  • Adjust "Generate new recovery codes" loading button due to selector changes
  • Adjust TOTP authenticator description due to new string
  • Listen for changes to TOTP via JS and adjust our custom TOTP save routine since TOTP saving uses the REST API since v0.8.
  • Remove custom JS that is no longer applicable
Actions #2

Updated by Boone Gorges 28 days ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF