Support #2060
closedAdd Digital University Theme to Commons
0%
Description
Hi Boone,
Can you consider adding the digital university theme to the Commons and making it exclusive to this site: http://digitaluniversity2010.commons.gc.cuny.edu/
It's an edited version of iNove theme. Final look can be demoed here: http://digitaluniversity.gc.cuny.edu
Assigning this to 1.4.3 because it's hopefully pretty simple, but feel free to push it back if it's going to cause too much extra work at the moment.
Files
Updated by Boone Gorges over 11 years ago
- Assignee changed from Boone Gorges to Dominic Giglio
Dom, can I ask you to do this please?
- Download the theme and add to your local 1.4.x branch
- Run it through the Theme Check plugin (I think this is in Dashboard > Appearance). Take note of any severe looking issues
- Assuming there are no severe issues - use your judgment - go ahead and commit it
- Add a note to https://github.com/castiron/cac/wiki/Release-ACTION_REQUIRED-list (you'll need a new section for this release) reminding the release manager (me) to make the theme available to the appropriate blog.
Thanks, and let me know if you have questions.
Updated by Dominic Giglio over 11 years ago
Thanks for starting this issue. I was just thinking about how to start, and this is almost exactly what I was thinking about. A short intro from the original emails and then a quick overview to get me started. This already answers some questions I was going to ask.
I will start now and I'm sure I'll be back with some more questions.
Am I to assume that this currently takes precedence over any of my other issues?
Updated by Boone Gorges over 11 years ago
Sorry, forgot to add myself as a watcher :)
Yes, please do this first, as I want to get the 1.4.3 release out by the beginning of next week. I'll email you separately with some general comments about priorities. Thanks!
Updated by Dominic Giglio over 11 years ago
I added and then theme checked the attached Digital University theme. There were a few red flags about some antiquated function calls but I didn't see anything that would cause any serious issues. I've pushed the addition to 1.4.x:
https://github.com/castiron/cac/commit/388b421e3cf188e4b12b1cbafacceb520994dec4
I've also updated the ACTION_REQUIRED list (linked above) with a reminder to make it available to http://digitaluniversity2010.commons.gc.cuny.edu/
Let me know if you need me to update anything else or if you want me to close this issue out.
Updated by Matt Gold over 11 years ago
Thanks, Dom. Can you run the iNove theme through the checker, as well? The DU theme is a customized version of that theme. I'm curious to know whether the same red flags show up.
And at some point, we should probably run all installed themes through the checker, as I'm sure that some of our older ones are out of date.
Thanks for your work, Dom.
Updated by Dominic Giglio over 11 years ago
I didn't do a line by line exact comparison, but both themes (iNove and Digital University) look almost exactly the same when run through the theme checker.
After I post this update I'll find the issue that's already open for theme cleanup and post there that we should run theme checker on all themes. That way we won't forget.
Updated by Dominic Giglio over 11 years ago
Boone,
Do we close this issue now, or wait for the site admin to confirm the theme works as requested?
Updated by Boone Gorges over 11 years ago
- Status changed from Assigned to Resolved
Dom - I think we can close now. If there are issues after release, we'll handle them in a new ticket.