CUNY Academic Commons

Thanks for forwarding these along, Steve.

Just to clarify: This is for announcements only, correct? When you post, eg, a forum reply, you only receive one notification?

If that's right, then this is not too pressing an issue, as the Group Announcements feature is not widely used, and in any case the double announcement is more annoying than anything else.

Excellent - thanks for the additional info, Steve.

Dom, this functionality is in a plugin called cac-group-announcements. Have a look there to see if you can see any obvious reason why the sender of a group announcement would be getting more than one notification of it. If you have questions about how the plugin works, just let me know (I wrote it, though it's been years since I've looked at how it works).

Boone,

I've been cross testing this issue with #2152.

This one was a little harder to debug but I think I've narrowed it down to the GES plugin. I started debugging the same way I did in #2152, by commenting out anything that looked related to sending an email. That got crazy way too fast, so I decided to check for more general plugin conflicts.

There didn't appear to be any Network Plugins enabled in my local env that could be causing the duplication of emails when an Announcement is submitted, so I moved to the active plugins for The Commons site specifically. I disabled, tested and then re-enabled the cets_blog_defaults, Invite Anyone, Mass Mailer and finally the GES plugin one by one. The only plugin that affected the output was GES. When GES is on it dumps two $phpmailer objects for each announcement. And it dumps two per group member when the "Email this update to all group members?" checkbox is checked. So if I'm in a group with 23 members, it dumps 46 objects. When it's disabled there is no output at all. So I think there is some code in GES that is doubling up on the emails. Maybe an extra action or filter?

This is where I'm continuing my debugging but I wanted to get some feedback to you incase you've got an idea of where I should look specifically.

Thanks for the report, Dom.

There shouldn't be an issue with GES, as there's a remove_action() in cac_email_activity_handler() (bp-custom.php) that explicitly prevents GES from firing: remove_action( 'bp_activity_after_save' , 'ass_group_notification_activity' , 50 ); And, in fact, when I put a var_dump() into the GES function ass_group_notification_activity(), I see that it's not actually run when group announcements are fired.

It turns out, in fact, that the function cac_email_activity_handler() is getting fired twice. Since it happens at bp_activity_after_save, it must mean that the activity item is getting resaved at some point. I didn't want to spend a bunch of time figuring out why this is happening and whether it can be stopped, so I just put a little check into cac_email_activity_handler() to make sure it doesn't fire twice in the same pageload: https://github.com/castiron/cac/commit/997abc031803cc2062d95d5316db58554bca58f0 Not all that elegant, but it does the trick.