Feature #21495
openDeleting Entries from activitiy feed when corresponding item is deleted
0%
Description
A user asks:
"If we delete a post as moderators, the post still shows under activity. This is only a problem if the post was removed as problematic. Is there any way for deleted posts not to show under activity?"
Here is the group: https://commons.gc.cuny.edu/groups/m-a-program-in-biography-and-memoir/
I cannot tell if the group is connected to a site, so this user may be referring to forum posts or posts on a connected side fed to the group. Either way, I imagine the expected behavior should be: if a user deletes the original post, the post activity information should also be deleted from the group activity feed. Is this correct?
Files
.png){kind=link}
Related issues
Updated by Boone Gorges 11 months ago
Laurie, would you mind running tests with a couple of the content types you mentioned, to see if you can reproduce? Forum posts and blog posts have different sync mechanisms, and it would be helpful to know which is not fully working.
Updated by Laurie Hurson 11 months ago
I tested deleting blog posts and forum posts in this group -- https://commons.gc.cuny.edu/groups/class-name-71994816/
When I deleted the blog post on the site, or the post topic from the forum, both entry types were deleted from the group activity feed.
I am meeting with this user in December and will ask for more info to see if I can identify and isolate the problem they report.
Updated by Laurie Hurson 9 months ago
Hi All,
This issue has come up again related to library items. In the group linked below the professor uploaded a test doc to the library and then deleted it but the info about upload is still in group activity feed
Updated by Boone Gorges 9 months ago
- Target version set to 2.6.0
We'll try to look at this after the migration.
Updated by Boone Gorges 2 months ago
- Related to Feature #21835: Activity items should have 'delete' button added
Updated by Boone Gorges 2 months ago
- Subject changed from Deleting Entries from activitiy feed to Deleting Entries from activitiy feed when corresponding item is deleted
- Target version changed from 2.6.0 to 2.7.0
Let's handle the creation of a Delete link in #21835, as there are visuals attached to that ticket.
I'm unsure about deleting the items from the activity stream when the corresponding item is deleted. I guess this is OK with me if others agree. This change would presumably affect the following:
- Delete bp_doc_created, bp_doc_edited items when the corresponding Doc is deleted
- Delete added_group_document, edited_group_document when the corresponding Library file is uploaded
- Delete bbp_reply_create when a forum reply is deleted
- When a forum topic is deleted, delete bbp_topic_create items, as well as bbp_reply_create items associated with replies belonging to that topic
- Delete new_blog_comment items when corresponding blog comment is deleted
- When a blog post is deleted, delete correpsonding new_blog_post activity item, as well as the new_blog_comment activity items corresponding to comments on that post
What do others think? Do we want to pursue this?
Updated by Colin McDonald 2 months ago
Hi Boone, this sounds right to me about corresponding items being deleted automatically when one is deleted manually. Otherwise, we're potentially displaying dead links / nonexistent excerpts of content, right?
Also, does all of this track with what happens in a non-activity-stream sense when something is deleted? For example, if someone deletes a forum topic, that deletes all of the posts and post replies under that topic? I hadn't really thought before about how one deletion can potentially impact so many others nested underneath it, but I suppose that's on the user to understand. It seems like our activity stream deletions should reflect what happens on the rest of the site.
Updated by Colin McDonald about 1 month ago
I wanted to close this ticket out but thought I'd confirm that in the #21835 release this week we went ahead with making the deletions of associated items happen as Boone outlined above.
Updated by Raymond Hoh about 1 month ago
Updated by Colin McDonald about 1 month ago
No problem Ray, and I think so regarding Boone's approach, but since we have the team-wide meeting tomorrow, let's see if we get a minute to go over this as a group before implementing. I'll make a note to return to this then.
Updated by Raymond Hoh about 1 month ago
- Category name set to Groups (misc)
- Target version changed from 2.7.0 to 2.6.0
I've duplicated the bug in comment 3 where the corresponding activity item would not be removed when deleting a file from the Group Library. Fixed in https://github.com/cuny-academic-commons/cac-group-library/commit/19ec5fe0ca67d56f98e1ed8000519c0c9052ef87. This is currently part of 2.6.0, but I can push this fix to the next 2.5.16 maintenance release as well; I just want to do a bit more testing to see if there are any other affected activity items that need to be removed.
Updated by Colin McDonald about 1 month ago
Thanks Ray, I think whenever you feel comfortable with the testing (and let me know if you want more eyes on it) it would be good to get this out since right now it's a bug.
Just recording our conversation from Friday on this the best I can summarize and grasp, but what we want to do in this ticket is ensure that when an actual item on the Commons is deleted, like a forum topic or a library file, its corresponding activity items (i.e. the items in activity feeds that serve as a 'record' or 'notification' of that item's creation are also deleted. This prevents dead or confusing activity items from appearing and directing people to an actual item that is already gone.
This is distinct from what we did in #21835 which was only about allowing activity items to be deleted. That deletion has no bearing on the actual items to which those activity items are linked.
Hopefully that's helpful and not missing anything -- please free to correct me if I'm wrong.