Bug #21885
closedGroup creation produces 2 erroneous groups
0%
Description
Hi All,
I was just on a zoom call with a faculty member to get a course up and running.
She created a group for her course "proseminar in music pedagogy" here: https://commons.gc.cuny.edu/groups/proseminar-in-music-pedagogy-1513049226/
When we went to check the course directory to make sure students knew where to find it and could request to join. The course directory shows three groups were created. See screenshot.
Here are the links to the other groups that we did not create but were created as a result of a possible bug. These groups also seem to be missing certain areas of groups such as events, send invites, and manage.
https://commons.gc.cuny.edu/groups/proseminar-in-music-pedagogy-1964774316/
https://commons.gc.cuny.edu/groups/proseminar-in-music-pedagogy/
Files
Related issues
Updated by Boone Gorges 6 days ago
Thanks for the report. Did you notice anything strange when you were creating the group? Delays, error messages, unexpected page refreshes, etc?
I see that three groups were created, with a few seconds in between each one. The "correct" (ie fully created) group is the third of these:
MariaDB [wp_1153337]> select id, slug, date_created from wp_bp_groups where slug li ke 'proseminar-in-music-ped%'; +------+-----------------------------------------+---------------------+ | id | slug | date_created | +------+-----------------------------------------+---------------------+ | 3401 | proseminar-in-music-pedagogy | 2025-01-27 20:28:34 | | 3403 | proseminar-in-music-pedagogy-1964774316 | 2025-01-27 20:28:42 | | 3405 | proseminar-in-music-pedagogy-1513049226 | 2025-01-27 20:28:49 | +------+-----------------------------------------+---------------------+
My initial diagnosis is that there was some delay in the creation of the group, and the creator clicked the Continue button several times. This is mirrored in the access logs:
98.13.44.163 - - [27/Jan/2025:20:28:34 +0000] "POST /groups/create/step/group-details/ HTTP/2" 200 - "https://commons.gc.cuny.edu/groups/create/step/group-details/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36" 98.13.44.163 - - [27/Jan/2025:20:28:41 +0000] "POST /groups/create/step/group-details/ HTTP/2" 200 - "https://commons.gc.cuny.edu/groups/create/step/group-details/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36" 98.13.44.163 - - [27/Jan/2025:20:28:48 +0000] "POST /groups/create/step/group-details/ HTTP/2" 302 - "https://commons.gc.cuny.edu/groups/create/step/group-details/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36"
Does this seem possible? Ideally, the system would detect these duplicate clicks (or prevent them) so that this didn't happen, but either way it would be helpful to know if you thought this might be the root cause.
Updated by Laurie Hurson 6 days ago
She was sharing her screen with me and yes, she definitely clicked the create button several times. So this is likely the cause.
I think she could not tell if the click registered and the next page was loading (likely due to having many tabs open and not being able to see the loading indicator as designed in chrome UX, which appears in the tab when there are fewer tabs open...)
Updated by Boone Gorges 6 days ago
- Related to Feature #21887: Disable group creation button while requests are in process added
Updated by Boone Gorges 6 days ago
- Status changed from New to Reporter Feedback
- Target version set to Not tracked
Thanks for confirming. I've created #21887 to put a fix in place that prevents future cases like this.
At this point, the user could clean up the unneeded groups. Or let me know if you need me to do it for you.
Updated by Laurie Hurson 6 days ago
Thanks Boone!
I'll have the instructor delete the extra groups.