Project

General

Profile

Bug #2230

MESTC page scrambled

Added by Matt Gold over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority name:
High
Category name:
WordPress (misc)
Target version:
Start date:
2012-11-05
Due date:
% Done:

0%

Estimated time:

Description

Hi All --

The homepage of the Martin E. Segal Theatre appears to be scrambled - http://thesegalcenter.org/ (scroll down the page - content is pushed too far down).

Kimon, who has a new baby at home, took a quick look and wrote the following:

Just looked at it quickly and I think that three templates for Index, Home, and Events pages might be missing.

template-events-page.php
template-home-page.php
template-index-page.php

If they somehow got deleted could someone reupload the most recent version of the MESTC theme.

Dom, can you take a look at see what's going on? Many thanks.

History

#1 Updated by Boone Gorges over 9 years ago

Dom - FYI, it looks like the culprit is probably the upgraded Thematic parent theme. If there is a simple fix that we can implement, please do so. If it looks like it's going to be complicated, let's just roll back to the previous version of Thematic for 1.4.10.

#2 Updated by Dominic Giglio over 9 years ago

  • Target version changed from 1.4.10 to 1.4.11

Boone,

You're right, Themeatic made changes to how they internally handle their themeatic_body_class and themeatic_post_class filters. This was causing weird output to show up in the <body> tag and therefore breaking the MESTC layout.

I've made some changes to MESTC's functions.php that I believe will fix this issue. I used the recommendations from this forum post:

http://thematictheme.com/forums/topic/upgrading-to-v-1-0-3-1-and-body_class-in-functions-php/page/2/#post-2488

I also updated Themeatic in our repo to v1.0.3.3-beta available here. One of the changes in this version addresses this issue specifically. I will upgrade our repo to the final version once it's released.

It's difficult for me to say for sure that these changes will fix the issue because my local MESTC site doesn't look like the live site. Hopefully when 1.4.10 is released on Sunday the site will be back to normal. I'm moving this issue to 1.4.11 for now, if all goes well I will move the issue back to 1.4.10 and mark it resolved as part of that milestone on Sunday/Monday. I've also added a reminder to ACTION_REQUIRED.

I will email my edited copy of function.php to Kimon so he has an up-to-date version for his own copy of the theme.

Here are my changes: https://github.com/castiron/cac/commit/63de971a4f4f4cc48a84c4d2bd63b70b87b0b9f6

#3 Updated by Matt Gold over 9 years ago

  • Priority name changed from Normal to High
  • Target version changed from 1.4.11 to 1.4.10

Upgrading the priority since MESTC has an event coming up on Monday and we should try to get this resolved by then. I suggest that if we find, on the 1.4.10 update, that the changes above don't fix the issue, that we upload the older version of the theme to ensure site consistency while we work out other issues on our dev server. It would be excellent if we could have this solved on the 11th or before.

Dom, Boone: thoughts?

#4 Updated by Dominic Giglio over 9 years ago

It sounds to me like the smartest thing to do is for me to be sitting in front of my computer Sunday night while Boone is releasing 1.4.10. As soon as he tells me it's live, I'll check The Segal Center. If it's not fixed I can then spend the rest of Sunday night tweaking it so that it's good to go for Monday morning. Boone and I can push successive 1.4.10.1, 1.4.10.2, etc, whatever, until it works. Even if that means rolling back to a previous theme version.

I'm not sure if testing on cdev is gonna be any better than my local testing. It's the settings in the production db that I can't replicate. Things like menus and widgets and plugin configs that control a large portion of the front of the site. I can say that I saw the debug error output in my local env and my changes fixed those errors. So I'm pretty confident that the site will look the way it's supposed to on Sunday night, not 100% though because that's impossible. :-)

#5 Updated by Matt Gold over 9 years ago

Cool. Thanks for your care and attention to this, Dom.

#6 Updated by Dominic Giglio over 9 years ago

No prob, whatever it takes - I'll make sure they're lookin good on Monday morning. :-)

#7 Updated by Kimon Keramidas over 9 years ago

Dom,

Thanks so much for you help. I tried your functions.php file on my local dev and it didn't fix all of the problems. I was however able to spend a couple of hours on the site and I now believe that I have fixed all of the problems(the upgrade had broken our category color palette and that took some fixing on CSS as well as PHP side) on my Local Dev set up and it should be compatible with the version of Thematic Dom noted in his functions.php version 1.0.3.3. The problem was with the way that the site was handling and constructing the "class" setting for body and post sites. I altered the childtheme override code to make it work with the new Thematic code. I think that they are having a little problem with how this is playing with people's sites and it looks like there are further fixes on the horizon that I will be on the lookout for.

I have shared a new version of the MESTC site theme at the following address (https://spideroak.com/browse/share/Kimon/mestcKK12commons) and that should solve the issues (as well as squash a couple of pre-existing non-critical bugs). Hope that this gets in in time for 1.4.10.

By the way here are the files that I changed:

mestc/functions.php
mestc/library/styles/default.css
mestc/events/events.css

Thanks for all your help while I've been on daddy-time. I'm glad I was able to get in some time for a full fix, but Dom's would have been a great partial fix and I appreciate the time you guys spent on that as I was unsure I would be able to do this work.

Cheers
Kimon

#8 Updated by Dominic Giglio over 9 years ago

Kimon,

You're welcome, glad I could get at least a partial fix in for you. I've added your latest code to the repo so it will be included in the 1.4.10 release. The first thing I'm going to check tomorrow night while Boone and I are pushing the release if the MESTC site. So I will be updating here as soon as I have more info. Matt informed me above that you have an event on Monday that the site needs to be ready for. We're gonna do all we can to make sure that happens.

As far as Themeatic goes, from what I read in a few forum posts, this update did indeed break quite a few sites. They deprecated some pretty important functionality. But there are times when this is necessary and unfortunately fixes like these are the only way to get through it. I'll be back with an update as soon as I've seen how the new code affects the site.

Commit: https://github.com/castiron/cac/commit/8962f9ddf7d0c863db75434475a99ca32cf05005

#9 Updated by Matt Gold over 9 years ago

Thanks, all, for your work on this. Moving forward, we should always keep theme files updated with new versions, since they could potentially address security vulnerabilities, but now we know that the Thematic developers have a history of breaking sites with their upgrades, so we should pay attention to MESTC the next time we upgrade Thematic.

#10 Updated by Kimon Keramidas over 9 years ago

My thoughts exactly Matt. If you guys do know when you are doing a Thematic upgrade in the future let me know so that I can do a test on my local dev setup to preempt any breaking.

Once again thanks for everything and thanks for paying attention to this tomorrow Dom

K

#11 Updated by Boone Gorges over 9 years ago

Dom - FYI, I'll be doing this release in the next hour or so. I'll ping you when it's ready, so that you can have a look.

#12 Updated by Boone Gorges over 9 years ago

The 1.4.10 release is live. Take a gander.

#13 Updated by Dominic Giglio over 9 years ago

Kimon,

MESTC is lookin' good again. I think our edits did the trick. Please take a look and verify. I'm leaving this issue open until you confirm that everything is working as you expect.

#14 Updated by Dominic Giglio over 9 years ago

Matt,

I'm sure Kimon is still pretty busy with the new baby. Since we haven't heard anything more about problems with MESTC, and their Monday event has passed, do you think I can safely close this issue?

#15 Updated by Dominic Giglio over 9 years ago

  • Status changed from Assigned to Resolved

Since we haven't heard back about problems with the MESTC site, I'm marking this issue as resolved.

Please open a new issue if any new errors are experienced.

Also available in: Atom PDF