Project

General

Profile

Actions
Copy link

Bug #22604

closed

businessbuilder theme escapes custom header URLs in such a way that private S3 paths are broken

Added by Boone Gorges about 20 hours ago. Updated about 20 hours ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
S3 Uploads
Target version:
2.5.7
Start date:
2025-04-21
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Reported in https://redmine.gc.cuny.edu/issues/22313#note-11

This happened previously with the Ashe theme: #21929

Related issues

Related to CUNY Academic Commons - Bug #22313: S3 IMage issues on private to public siteResolvedBoone Gorges2025-03-13

Actions
Related to CUNY Academic Commons - Bug #21929: Header image keeps disappearingResolved2025-01-29

Actions
Actions
Copy link
 #1

Updated by Boone Gorges about 20 hours ago

  • Related to Bug #22313: S3 IMage issues on private to public site added
Actions
Copy link
 #2

Updated by Boone Gorges about 20 hours ago

  • Related to Bug #21929: Header image keeps disappearing added
Actions
Copy link
 #3

Updated by Boone Gorges about 20 hours ago

  • Status changed from New to Resolved

Similar to #21929, this theme calls a WP function that uses esc_url() in a way that causes the necessary S3 URL params to be stripped.

The businessbuilder theme appears to be abandoned, so I feel OK making the necessary changes directly to the theme. First, I took our custom sanitization routine and moved it into a reusable utility: https://github.com/cuny-academic-commons/cac/commit/1548a4f656fc0fb919da11be23a939daaba869ad Then, I used that function to rewrite the way that businessbuilder creates its header markup: https://github.com/cuny-academic-commons/cac/commit/8df9f824d10d3c461f25d44307ecaf14e0c9fe87

This is deployed on the production site.

Actions
Copy link
 #4

Updated by Laurie Hurson about 20 hours ago

Thank you Boone!

Actions
Copy link

Also available in: Atom PDF