Project

General

Profile

Bug #2498

Deprecate Atahualpa theme

Added by Boone Gorges almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority name:
Normal
Category name:
WordPress (misc)
Target version:
Start date:
2013-02-28
Due date:
% Done:

0%

Estimated time:

Description

Atahualpa is a very problematic theme on WPMS, and the devs have refused to accept the patches I've sent in the past. I'd like to prevent people from selecting it in the future. Dom, can you look into setting something up along the links of what's in place for plugins?

History

#1 Updated by Matt Gold almost 9 years ago

sounds good to me.

#2 Updated by Dominic Giglio almost 9 years ago

Boone,

I'm starting on this now, hoping that it's one of those tickets I can start and knock right out.

Just so you and Matt are aware, here's a list of all the sites currently running Atahualpa:

bobbybrody
majoring in meta
CUNY Pie
History of Urban Public Education
The CUNY Graduate Center ITP Core I Blog
Techno Jazz
Anthropology Dissertation Workshop
testing blogs
Turf Walls
just a test
Tadlas's Talk
Feriadebyonne
Bilanski
Estudiar Algo
RobertTrace
RobertTrace
AllegraSoderstrom
ChingValderamo
CristobalBzhyan
Andrew Newman
NYC Nursing Education Consortium in Technology
test-shawn
Gslis751 Digital
Madness and Civilization
CUNY 2012
Tech Tips
LocateFlow
Year of China Travelogue
Moment: Une Revue de Photo
Natural Science Seminar Series at York College
QC Ad Hoc Committee to Study CUNY Pathways
Natural Science Seminar Series
Lisa Larsen
Gslis720 Digital
testing for gslis720
International Law Society Digest
CMT31 Sound Recording & Editing
gslis790.3 digital
bikeCUNY
Keith K Miyake at the CUNY Academic Commons
Committee on Globalization and Social Change
The Committee for Interdisciplinary Science Studies
The Committee for the Study of Religion
TEQSENSE
Teaching and Learning Tips
The Center for Place, Culture and Politics
RHISC Virtual Conference
QC ADJUNCTS

I'll update here as soon as I've got a potential fix.

#3 Updated by Dominic Giglio almost 9 years ago

Boone,

I've been looking into first updating the plugin hiding function we already have to also hide themes. But where class-wp-plugins-list-table.php uses the all_plugins filter when preparing the table for the admin (which is how we're removing unwanted plugins), class-wp-themes-list-table.php uses wp_get_themes() instead.

At first I thought this would make it harder since there's no easy to access filter. But it reminded me that themes can be shown to users on a site by site basis when running WPMS. Wouldn't the correct way to go in this situation be to Network Deactivate the theme and only enable it on the above 48 sites? That would allow it to be used by existing sites but keep it hidden from all others. It is also something we can accomplish on the live site now without having to wait for new code to get released on the 11th.

Let me know if I'm missing something here. This seems like the WP way to do this, rather than code up another function that removes things from the admin. In the plugin situation we had no choice - here I think we do.

#4 Updated by Boone Gorges almost 9 years ago

  • Target version changed from 1.4.21 to Not tracked

Oh duh. Thanks for talking sense into me, Dom.

Please go ahead and Network Disable the theme, and mark this ticket Resolved. Thanks!

#5 Updated by Dominic Giglio almost 9 years ago

No prob, I'll do this today. One quick question first though:

I'm curious (worried) that Network Disabling the theme might cause an inadvertent problem with the above 48 sites. Do you think they will revert back to the default theme (twentytwelve) once Atahualpa becomes unavailable network wide? I'm wondering if I need to make the theme available to each of the above sites individually AFTER Network Disabling it? Some of them are kinda large and high profile.

#6 Updated by Boone Gorges almost 9 years ago

I'm 99% sure that Network Disable just removes it from the Themes screen on individual blogs. It does not deactivate the theme where it's already in use.

You may want to test this out on your local, just to be sure.

#7 Updated by Dominic Giglio almost 9 years ago

will do, I'll mark this as resolved when I'm done.

#8 Updated by Dominic Giglio almost 9 years ago

  • Status changed from Assigned to Resolved

I double checked on my local install first and verified that when a network enabled theme is active on a blog and then network deactivated it remains active for that blog.

So I've network disabled Atahualpa so no new sites will be able to activate it.

Closing as resolved.

Also available in: Atom PDF