Project

General

Profile

Support #2535

questions for funding website/luna wordpress theme

Added by Dominic Giglio over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority name:
Normal
Category name:
WordPress (misc)
Target version:
Start date:
2013-04-06
Due date:
% Done:

100%

Estimated time:

Description

Erin,

I've created some new templates in the luna-fellowships child theme folder to address your request to add the GC's logo to the header area. I say "header area" because technically I've tweaked the code in the "slide-text" div. This is the same div we worked on to make the Provost's header area consistent. This new code will cause the GC logo to be displayed on any page that uses the index.php and homepage-alt.php templates (the ones I've added to the child theme). The only reason I'm bringing this up is because not all pages use these templates. I didn't want to go overboard and start editing all the templates; I think we should see how this change looks after the next release on the 11th and move forward from there. Adding that logo to every single page is going to require some extensive edits. For example: pages (page.php) do not use the slide-text div, and therefore will not display the logo. I believe incremental updates are far easier to manage. We can look at what does and does not display the logo and decide together if further templates need to be altered. We release three times a month so one addition now and another (if needed) on the 21st shouldn't be too long of a wait. Let me know if you're on a stricter time schedule and we'll do what we need to do.

On (or around) release day I'd like to talk to you about your Custom CSS. There's some duplication and edits I'd like to go over. Just a little house cleaning really. I looked at what you had in there and edited the header.php template to make some of it unnecessary. It's better to not have the HTML structure there if you're going to be hiding it. Between my new header.php and your custom CSS the header should be a little cleaner. I've edited the Custom CSS on my local install and will paste it into an update to this ticket so you can compare it to what you currently have. That will also make it easier to paste directly into the live site after the next release.

Looking at your homepage posts question I assume you're talking about the posts that appear in the slider. If this is correct I only see one way to manage what is displayed there. In the Luna Theme Options (Appearance->Theme Options in the Admin) under the heading "HOMEPAGE" there are four options for controlling that slider. "Slider Order" and "Slider Order By" appear to be the only ways of controlling the order of the posts. Right now you're displaying items from the News category and they are ordered by ascending (ASC) ID. If you experiment with the Slider Order By dropdown you may be able to get a better or more desirable output. If I'm completely off-base here, let me know. I may not understand your request correctly.

Let me know if you'd like me to zip up my local, edited version of the luna-fellowships child theme folder and email it to you. That will allow you to check out the changes on your local machine before the release. I didn't want to attach it to this ticket because it's public and wasn't sure if there was anything in the theme that shouldn't be available to everyone. I can email it or attach it to this ticket, doesn't matter to me either way.

As always, let me know if there are problems or questions.

Commit: https://github.com/castiron/cac/commit/c72aa8b38ee9abb98778ef1d4f0db0be02f01e90

History

#1 Updated by Dominic Giglio over 6 years ago

Erin,

Below is my edited Custom CSS. I've removed some styles due to the new custom header.php template and also tried to organize your existing styles so you can see some of the duplication.

body {
  color: #282828;
  font: 12px/1.8em;
  margin: 0 0 50px;
  overflow-x: hidden;
}

body {
  color: #000000;
  font: 14px1.8em arial, sans-serif;
  margin: 0 0 50px;
  overflow-x: hidden;
}

.menu {
  font-size:14px;
  width: auto;
}

.menu ul li a:link, .menu ul li a:visited {
  font: 700 15px Open Sans, sans-serif;
}

.menu-search {
  width: auto;
}

#site-contents {
   margin-top: 0px;
   padding: 20pt 20px 20px;
}

.slide-text img {
  float: right;
  height: 100px;
}

.slide-text, .ptitle {
   border-top: 0px;
}

.slide-text h1, h2.ptitle {
  color: #A8A8A8;
  display: block;
  font: 700 40px;
  margin-bottom: 1px;
  padding-top: 10px;
  text-transform: uppercase;
}

.slide-text span.subtext {
  color: rgb(159, 159, 159);
  font: 20px 'Open Sans', sans-serif;
}

#wpadminbar {
  display:none
}

.sitewide-footer, td#footer .sitewide-footer {
  display: none!important;
}

.latest-works {
  margin-top: 33px;
}

.footer-widget {
  color: rgb(200, 200, 200);
}

.testi-bg {
  color: rgb(200, 200, 200);
}

span.tweet_text {
  color: rgb(200, 200, 200);
}

a:link, a:visited {
  color: rgb(160, 160, 160);
}

a:link, a:visited {
  color: #4C4C4C;
}

a:link, a:visited {
  color: rgb(100,100,100);
}

.footer-widget {
  background: none repeat scroll 0% 0%
  rgb(60, 60, 60);
}

label.copyright {
  display: none;
}

.pdesc {
  float: right;
  width: 500px;
  position: relative;
  bottom: 500px;
  right: 20px;
}

.sf-menu li:hover ul, .sf-menu li.sf Hover ul {
  top: 4.6em;
}

.sf-menu li:hover ul, .sf-menu li.sfHover ul {
  width: 400px;
}

#comments {
  display: none;
}

div.slideshow {
  height: 500px;
}

h4 {
  font-size: 20px;
  color: #4C4C4C;
}

input, textarea, select {
  width: 280px;
}

#2 Updated by Matt Gold over 6 years ago

Thanks for this, Dom.

#3 Updated by erin glass over 6 years ago

Thanks so much, Dom! See below for my responses:

I've created some new templates in the luna-fellowships child theme folder to address your request to add the GC's logo to the header area. I say "header area" because technically I've tweaked the code in the "slide-text" div. This is the same div we worked on to make the Provost's header area consistent. This new code will cause the GC logo to be displayed on any page that uses the index.php and homepage-alt.php templates (the ones I've added to the child theme). The only reason I'm bringing this up is because not all pages use these templates. I didn't want to go overboard and start editing all the templates; I think we should see how this change looks after the next release on the 11th and move forward from there. Adding that logo to every single page is going to require some extensive edits. For example: pages (page.php) do not use the slide-text div, and therefore will not display the logo. I believe incremental updates are far easier to manage. We can look at what does and does not display the logo and decide together if further templates need to be altered. We release three times a month so one addition now and another (if needed) on the 21st shouldn't be too long of a wait. Let me know if you're on a stricter time schedule and we'll do what we need to do.

Great! I think it's perfectly reasonable to start with the logo only on the homepage and index page. After launch, we can see how much time it would require to place the logo on the remaining pages and whether it's worth the time.

Also, I'm glad you reminded me of the fix you worked out for making the header consistent across the Provost's website. Would it be easy to add the same fix to the fellowships site?

On (or around) release day I'd like to talk to you about your Custom CSS. There's some duplication and edits I'd like to go over. Just a little house cleaning really. I looked at what you had in there and edited the header.php template to make some of it unnecessary. It's better to not have the HTML structure there if you're going to be hiding it. Between my new header.php and your custom CSS the header should be a little cleaner. I've edited the Custom CSS on my local install and will paste it into an update to this ticket so you can compare it to what you currently have. That will also make it easier to paste directly into the live site after the next release.

Thanks for taking a look at my custom CSS. I believe it got a bit messy as I was frantically experimenting. I will compare your cleaned up version with mine and implement it after the new release.

Looking at your homepage posts question I assume you're talking about the posts that appear in the slider. If this is correct I only see one way to manage what is displayed there. In the Luna Theme Options (Appearance->Theme Options in the Admin) under the heading "HOMEPAGE" there are four options for controlling that slider. "Slider Order" and "Slider Order By" appear to be the only ways of controlling the order of the posts. Right now you're displaying items from the News category and they are ordered by ascending (ASC) ID. If you experiment with the Slider Order By dropdown you may be able to get a better or more desirable output. If I'm completely off-base here, let me know. I may not understand your request correctly.

Actually I'm talking about the blog posts below the slider. I ended up making the slider items "news items" not blog posts as it allowed me to better control what shows up in the slider. I did in fact try the same changes you suggest in the Luna Theme Options, but for some reason the order of the blog posts were not affected. I think this is just another annoying feature of this theme, but for the meantime, the current workaround works well enough.

#4 Updated by Dominic Giglio over 6 years ago

Also, I'm glad you reminded me of the fix you worked out for making the header consistent across the Provost's website. Would it be easy to add the same fix to the fellowships site?

Yes, this shouldn't be a problem. We'll revisit in a new ticket after the next release - once we decide how the current changes to the header look.

Actually I'm talking about the blog posts below the slider.

This one confused me at first, until I realized that all blog posts are "Featured Students." At first I thought featured students were a particular category or even a custom post type and they were being displayed in a special way on the homepage. But after looking around a little I see what's going on. Unfortunately it doesn't look like the theme provides the functionality you're looking for. It doesn't allow you to choose different ordering options like portfolio items or even the slider. Those are the Theme Options you're looking for.

Now, with all that being said, we are working towards turning you into a child theme expert. The template used to display the homepage is called home-default.php. The code responsible for displaying the blog post section starts on line 151. But the interesting lines are 159, 160 and 161.

159 defines an array of arguments that are supplied to the call to WP_Query() on the next line
160 calls WP_Query() to get the posts from the database, storing the response in the $wp_query variable
161 is the for() loop that actually outputs each post in a two column format

Your job now is to read through the codex page for the WP_Query() function to see if there are arguments we can add to this template to pull in the posts in whatever order you'd prefer. As always let me know if you have questions.

By now I'm sure you know that all we have to do is copy this template into our child theme folder and edit those arguments to suit our needs. We will then have a homepage that works exactly the same way as the current one, except with a custom request for blog posts. One that goes a little further than the current Luna Theme Options allow us to. Ah the beauty of child theming. :-)

#5 Updated by erin glass over 6 years ago

Great! Will be fun to get my hands dirty again with child theme-ing. I'll let you know what I find. Thanks!

#6 Updated by Dominic Giglio over 6 years ago

  • Target version changed from 1.4.24 to 1.4.25

Moving this ticket to 1.4.25 so we can review the changes after the next release.

#7 Updated by Dominic Giglio over 6 years ago

Erin,

This is a reply to your email regarding the fellowships header.

Due to the changes I made to the header template the Custom CSS needed to be replaced with my new CSS that I posted above.

I've replaced the CSS so the site should look the way you wanted it to now.

Below is the CSS you used to have in there, incase you'd like to compare:


.menu { float:left; width:1000px; margin-top:-5px; font-size:14px;}

#site-contents {
     margin-top: 0px;
     padding: 20pt 20px 20px;
}
.searchbox {display:none;}

.slide-text, .ptitle {
   border-top: 0px;
}

#wpadminbar {
display:none
}

.sitewide-footer, td#footer .sitewide-footer {
display: none!important;
}

.latest-works {
   margin-top: 33px;
}

body {
    color: #282828;
    font: 12px/1.8em;
    margin: 0 0 50px;
    overflow-x: hidden;
}

.slide-text h1, h2.ptitle {
    color: #A8A8A8;
    display: block;
    font: 700 40px;
    margin-bottom: 1px;
    padding-top: 10px;
    text-transform: uppercase;
             }

.slide-text span.subtext {
    color: rgb(159, 159, 159);
    font: 20px 'Open Sans', sans-serif;
             }

.menu ul li a:link, .menu ul li a:visited {
    font: 700 15px Open Sans, sans-serif;
              }

.menu { float:left; width:1000px; margin-top:-5px; font-size:14px;}

#site-contents {
     margin-top: 0px;
     padding: 20pt 20px 20px;
                  }

.slide-text, .ptitle {
   border-top: 0px;
}

.footer-widget {
color: rgb(200, 200, 200);
}

.testi-bg {
   color: rgb(200, 200, 200);
}

span.tweet_text {
    color: rgb(200, 200, 200);
}

a:link, a:visited {
    color: rgb(160, 160, 160);
}

.footer-widget {
   background: none repeat scroll 0% 0%
   rgb(60, 60, 60);
}

label.copyright {
  display: none;
}

.pdesc {
  float: right;
  width: 500px;
  position: relative;
  bottom: 500px;
  right: 20px;
}

.sf-menu li:hover ul, .sf-menu li.sf Hover ul {
    top: 4.6em;
}

#comments {
display: none;
}

div.slideshow {
    height: 500px;
}

body {
    color: #000000;
    font: 14px1.8em arial, sans-serif;
    margin: 0 0 50px;
    overflow-x: hidden;
}

a:link, a:visited {
    color: #4C4C4C;
}

h4 {
    font-size: 20px;
    color: #4C4C4C;
}

input, textarea, select {
    width: 280px;
}

a:link, a:visited {
   color: rgb(100,100,100);
}

.sf-menu li:hover ul, .sf-menu li.sfHover ul {
width: 400px;
}

#8 Updated by erin glass over 6 years ago

Awesome! Many thanks!

#9 Updated by Dominic Giglio over 6 years ago

  • Target version changed from 1.4.25 to 1.4.26

Erin,

I'm moving this ticket to 1.4.26 to give you some more time to investigate WO_Query().

Let me know if you'd like to continue a discussion about customizing the output of blog posts or if you'd like to shelve the idea for a while. If you want to wait, we should close this issue and open a new one when you're ready. Everything else we discussed in this ticket has been taken care of.

#10 Updated by erin glass over 6 years ago

Thanks! Let's close for now and revisit if there's time in the future.

#11 Updated by Dominic Giglio over 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF