Project

General

Profile

Actions
Copy link

Bug #2779

closed

Firefox Issue on Portfolio page when scrolling down

Added by scott voth over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
BuddyPress (misc)
Target version:
1.5.3
Start date:
2013-09-08
Due date:
% Done:

0%

Estimated time:
1.00 h
Deployment actions:

Description

Hi - Not sure if anyone else has noticed this - In Windows 7, using Firefox 23.0.1 - I notice that in some cases when a member's profile has no widget content below and less than four lines in the black area, and I try to scroll down, the screen start flashing when it attempts to make the header shorter. I tried with Chrome (which works great) and with Safari and IE (both do not try to minimize the header when content is so short - so no issue). But Firefox seems to go a little crazy.

I tried Firefox on iOS - for the same type of short portfolio - the header is shortened correctly - but there is a sliver of the blog address that shows (in blue) when you scroll down and make the header made smaller.

I tried several portfolios at random - it seems to occur only on really short portfolios. Here is an example: http://commons.gc.cuny.edu/members/cperezdiaz/

Actions
Copy link
 #1

Updated by Matt Gold over 10 years ago

  • Category name set to BuddyPress (misc)
  • Status changed from New to Assigned
  • Assignee set to Boone Gorges

I noticed this with Chrome at first, too, but it seems not to be happening any more. It is disconcerting when it does happen.

Actions
Copy link
 #2

Updated by Boone Gorges over 10 years ago

  • Target version set to 1.5.2
  • Estimated time set to 1.00 h

This issue was supposed to be fixed with https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/a771a18b57667e61ac3dbf79c55fcdc466618f85 (at least, it was improved), but I will have a second look.

Actions
Copy link
 #3

Updated by Boone Gorges over 10 years ago

  • Target version changed from 1.5.2 to 1.5.3
Actions
Copy link
 #4

Updated by Boone Gorges over 10 years ago

  • Status changed from Assigned to Resolved

The calculations required to decide whether to "snap" are very complicated, because they differ based on many factors: whether you're logged in (certain buttons are shown which make the document height greater); whether you're viewing your own profile (ditto, and also because of the yellow notices at the tops of pages); window height; profile height. Etc.

My best attempt at sorting the logic is in https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/34e46f9f078f34f19c0b411c718a534fe47c11c9 https://github.com/castiron/cac/commit/e61a3d0c1ef18b8cdbdad1638fbc0a944fb76d0d I think it's good enough.

Actions
Copy link

Also available in: Atom PDF