Project

General

Profile

Bug #2907

automatic slider down again

Added by erin glass over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority name:
High
Category name:
WordPress (misc)
Target version:
Start date:
2013-11-26
Due date:
% Done:

0%

Estimated time:

Description

Hello Dom!

I think the automatic slider functionality for Chase Robinson's website and the Fellowships website was lost somewhere along the way (perhaps the last update)? Let me know your thoughts. Thanks!

To refresh your memory, here's your comments from the update made several months ago:

I've created a new child theme for the Fellowships site using the same skeleton we used for the Provost's site; the one provided in the Luna theme zip. The only change I made was to enable the automatic activation of the slider's transition effect. So nothing else on the site should change.

I've added a note to ACTION_REQUIRED reminding Boone to enable the theme for this site.

Commit: https://github.com/castiron/cac/commit/6d3218585dff64fb748a97b5ce6269ff711b222e

History

#1 Updated by Matt Gold over 7 years ago

  • Status changed from New to Assigned
  • Priority name changed from Normal to High

Dom, please prioritize this. Thank you.

#2 Updated by Dominic Giglio over 7 years ago

Hey Erin,

I see that the slider is not automatically advancing between slides but I'm not seeing any errors in Chrome web inspector.

I'm checking the site's settings and investigating further right now - will update when I've got more news.

#3 Updated by Matt Gold over 7 years ago

Hi Dom,

Any updates? Again, this is a big priority and I would love for us to fix the slider ASAP, definitely by the 12/1 update if possible. Many thanks for your work.

#4 Updated by Dominic Giglio over 7 years ago

  • Target version set to 1.5.10

I've verified that this is not a javascript problem (as far as I can tell).

What I'm trying to determine now is whether or not a change was introduced in the recent upgrade to the 2.x version of the parent theme. I'll do everything I can to get a fix into the next release. I think it isn't broken, I think it just isn't starting automatically. Which (I'm pretty sure) is an issue we addressed when this site was first built. So as soon as I find where those slider settings are again, a solution should be no prob.

#5 Updated by Matt Gold over 7 years ago

Thanks, Dom -- I appreciate your work on this.

#6 Updated by Dominic Giglio over 7 years ago

Erin, Boone, Matt,

I figured out the issue.

The new version of the Luna theme no longer loads the files we created and included in our custom child themes. I can't remember how we solved this when we first built chasefrobinson.net (and Fellowships and Funding) but the most likely answer is that we customized the parent to load what it was supposed to load and the update overwrote those customizations.

I've taken a simple approach to resolving this issue: I've simply removed the code from the parent's javascript file that forces the slider to pause by default. The fix has already been pushed up and will be in today's release.

Commit: https://github.com/castiron/cac/commit/40abc7f10bf94f2b1169c04de5ff159191eb2093

#7 Updated by Matt Gold over 7 years ago

Fantastic -- thank you, Dom!

#8 Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.5.10 to 1.5.11

#9 Updated by Dominic Giglio over 7 years ago

  • Status changed from Assigned to Resolved

Welcome Matt, sorry for the delay.

I just verified that the fix is working on both Chase F Robinson and Fellowships & Funding.

Closing this ticket.

#10 Updated by erin glass over 7 years ago

Thanks, Dom!

Also available in: Atom PDF