Bug #2931
closedWP 3.8 Upgrade Breaks Topbar Icons
0%
Description
WordPress 3.8 has been installed on CDEV for testing. After taking an initial look, I found that the icons in the Topbar (adminbar) are no longer properly aligned.
I looked through the elements and styles in Web Inspector but I'm not seeing any obvious custom overrides that would be breaking that layout. I assume there is a custom function somewhere that may be overriding the styling, I'm looking into that now. If I missed any watchers, please add them.
Boone,
If you know where these styles may be getting overridden please give me a heads up. I'm going to assign this to myself for now, but if it should belong to someone else, please feel free to reassign.
Chris,
If you know where these styles may be getting overridden please let me know.
Related issues
Updated by Dominic Giglio over 10 years ago
If you delete the stylesheet (from web inspector) that is included by the cac-bp-admin-bar-mods plugin, the problem immediately disappears.
I assume the main function of those styling overrides is to make the adminbar taller to better display the logged in user's avatar?
Lowering the .ab-icon margin-top styling on line 37 of that file (to 4px from 12px) helps to bring the icons back inline but it's not perfect. There is some other collection of styles in that file that are cooperating to throw off the alignment. It's making it very difficult to debug.
Updated by scott voth over 10 years ago
I created a page on the Codex (http://codex.commons.gc.cuny.edu/wordpress-3-8-now-available-commons/) that provides a quick synopsis of the changes in WP 3.8. When we upgrade I will make it a post and publish.
Updated by Boone Gorges over 10 years ago
- Priority name changed from Normal to High
- Target version changed from Not tracked to 1.5.15
This is probably an issue with the new Genericons in WP 3.8. I did some similar fixes for openlab.citytech.cuny.edu, for referenc: https://github.com/livinglab/openlab/commit/84f679a7cf48c8eb29d0f5e2c8bf14aa4f5f315f
Updated by Dominic Giglio over 10 years ago
- Target version changed from 1.5.15 to 1.5.16
Updated by Boone Gorges over 10 years ago
- Target version changed from 1.5.16 to 1.5.17
Updated by Boone Gorges about 10 years ago
- Status changed from New to Resolved
- Assignee changed from Dominic Giglio to Boone Gorges
This is fixed in https://github.com/castiron/cac/commit/0ef3ae7d2de00e527674d6614b05faadb81def6e. I'll merge it into a release branch when we're confident that the upgrade is coming.