Feature #3191
closedFeature #3177: Upgrade bbPress to 2.x
Ensure compatibility of bbPress forum reply with 2.x
0%
Description
We're currently using a fork of Ray's https://github.com/r-a-y/bbp-live-preview to power live forum previews. See #589. We'll have to make sure that the original is working properly with the migrated forums.
This is a task that probably should wait until we've made any major modifications to the default bbPress templates (if any). We'll use #3177 for discussion of these more general tasks.
Updated by Boone Gorges about 10 years ago
Ping Ray. Should this just work out of the box?
Updated by Raymond Hoh about 10 years ago
Should this just work out of the box?
It should. It's been awhile since I've tested bbp-live-preview with bbPress though. Needs some thorough testing.
Updated by Raymond Hoh about 10 years ago
Just added some fixes for bbp-live-preview if a site is using TinyMCE 4 with bbPress in commit d6b1f2c.
Updated by Boone Gorges about 10 years ago
- Status changed from Assigned to Resolved
Thanks for the updates, Ray.
I forgot that I had already reviewed this and made the necessary changes. https://github.com/cuny-academic-commons/cac/commit/bc7075 https://github.com/cuny-academic-commons/cac/commit/5ee7c0
Going to close as resolved. If there are issues with the implementation, let's open new tickets. Thanks!
Updated by Raymond Hoh about 10 years ago
In the most recent commit, I think I wiped out the custom mods and styles that were hardcoded in https://github.com/cuny-academic-commons/cac/commit/5ee7c0.
Will look at adding these mods as custom hooks and adding the styles into the bp-nelo stylesheet.
Update
I've added the mods back in the latest commits and have also adopted most of these changes in the bbp-live-preview plugin!
Updated by Boone Gorges about 10 years ago
Thanks, Ray! And sorry for making those styling updates right inline - I saw you'd done the same, so I was just following suit :)