Project

General

Profile

Actions

Feature #3418

closed

Revisions/Additions to email notifications about group membership requests

Added by Matt Gold about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2014-08-28
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Just received a bunch of notifications for people to join a public group. A few suggested changes to the notification email:

1. If a note is included in the request, it (or an excerpt, if it is long) should show up in the email notification

2. there should be a line space between "X wants to join Y Group" and "View Notifications."


Files

Actions #1

Updated by Boone Gorges about 10 years ago

  • Target version set to 1.7

These seem like reasonable requests that should probably be accomodated at the level of BuddyPress. I'm going to put this ticket into the 1.7 milestone so I remember to move the requests over to the BP tracker, though it's unlikely that they'll appear in BuddyPress in time for CAC 1.7.

2. there should be a line space between "X wants to join Y Group" and "View Notifications."

Can you please share a screenshot of this? I don't see where the text View Notifications appears in this email, though I may be looking in the wrong place.

Actions #2

Updated by Matt Gold about 10 years ago

Thanks. Please see a screenshot attached. And, yes, you're right that "View Notifications" does not appear . . . but all of the links in the message are a bit jammed together.

Actions #3

Updated by Boone Gorges about 10 years ago

Thanks for the screenshot. What you're seeing there is a bug that I've fixed in https://github.com/cuny-academic-commons/cac/commit/d461c86bb927abc88eb848c07862d37488639d92. Leaving the ticket in the 1.7 milestone for the first suggestion.

Actions #5

Updated by Matt Gold about 10 years ago

Awesome. I know you are keeping track of upstream contributions, but I'm just going to add #upstream here to make such tickets easily searchable here.

Actions #6

Updated by Boone Gorges about 10 years ago

  • Status changed from Assigned to Testing Required
Actions #7

Updated by Boone Gorges about 10 years ago

  • Status changed from Testing Required to Resolved

Going to mark this one resolved, and we'll handle any bugs during the testing phase.

Actions

Also available in: Atom PDF