Project

General

Profile

Feature #37

Move Member Search up on Member page

Added by Matt Gold over 12 years ago. Updated over 12 years ago.

Status:
Resolved
Priority name:
Low
Assignee:
Category name:
BuddyPress (misc)
Target version:
-
Start date:
2009-10-10
Due date:
% Done:

0%

Estimated time:

Description

On the members page , I think we should move the member search up on the page, perhaps between Member Directory (alphabet list) and Member Listing (listing of members).

History

#1 Updated by Boone Gorges over 12 years ago

  • Status changed from Assigned to Reporter Feedback

Good idea. I've moved it on both the members and groups directory pages. Please let me know if it looks all right and close the ticket if you're happy.

#2 Updated by Matt Gold over 12 years ago

This looks good, but I do have two thoughts/suggestions:

1. Please see this bug report: http://issues.commons.gc.cuny.edu/issues/show/53

2. I think we should replace that default "Search Anything" text in the search box. Let's downplay our claims there. How about "Search Members" for the members page and "Search Groups" for the Groups page. Or nothing as default text in either box.

Thanks for your work on this.

#3 Updated by Boone Gorges over 12 years ago

Two issues:

1) I have changed the default text in the search boxes on directories for blogs, members, groups. Done via core hack as it's not very easily pluggable. bp_directory_members_search_form, bp_directory_groups_search_form, bp_directory_blogs_search_form are the functions where the changes were made.

2) The search box had stopped working because in moving the search box to the top of the page I had screwed up the form structure. I had to move the search box back to where it was in order to make the search work again. In order to move the box to the top, I would have to rewrite a fair portion of the search box markup to make sure that the security features line up correctly. My judgment is that it's not worth it because (familiar refrain) the structure of BP themes will make it such that hacking will not be necessary to put the search box near the top of the page. See http://boonebgorges.com/wpmutest/groups. Matt, is this OK with you?

#4 Updated by Matt Gold over 12 years ago

Thanks, Boone, and yes, of course that makes sense, though it does make me think, again, that we should try to go to 1.1 sooner rather than later. Let's see where we stand on the new design by the time you come back and we'll take stock then.

#5 Updated by Matt Gold over 12 years ago

  • Status changed from Reporter Feedback to Resolved

Looks like this is done, so I am closing this ticket.

Also available in: Atom PDF