Project

General

Profile

Feature #4390

Please evaluate theme and upload to Commons if OK

Added by Stephen Klein about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress Themes
Target version:
Start date:
2015-08-06
Due date:
% Done:

0%

Estimated time:

Description

Please evaluate theme and upload to Commons if OK.

Here is an informational link to the theme:
http://themify.me/themes/basic
Integrated with the Builder plugin:
http://themify.me/builder

I spoke to the vendor and they said:
You are allowed to use all purchased products on an unlimited number of sites. With that site, feel free to use it on another site if you’d like.

Jenny Furlong would like to use the theme for her CP site.

Here is a dropbox link to download theme and integrated builder plugin:
https://www.dropbox.com/sh/d684o2ek9cd3taj/AAAJROYQahZKHg4tAiq-8hvda?dl=0

Please let me know when you have downloaded and i will delete from Dropbox.

Thanks,
Stephen

gclibrary_themify_export_2015_08_13.txt (53.2 KB) gclibrary_themify_export_2015_08_13.txt Stephen Klein, 2015-08-13 11:22 AM
header.php (3 KB) header.php Jennifer Furlong, 2015-08-31 03:03 PM
custom-functions.php (1.29 KB) custom-functions.php Stephen Klein, 2015-08-31 03:12 PM

History

#1 Updated by Matt Gold about 6 years ago

  • Status changed from New to Assigned
  • Assignee changed from Matt Gold to Boone Gorges

#2 Updated by Stephen Klein about 6 years ago

Was it uploaded? Also, would you be able to upload the associated child theme:
https://www.dropbox.com/sh/ci00137jnyiwd3n/AAAXdKewquVAqvkLtL___3GQa?dl=0

Jenny will just need to modify the header.php file to point to her own logo images.

Thanks!

#3 Updated by Boone Gorges about 6 years ago

  • Category name set to WordPress Themes
  • Status changed from Assigned to Reporter Feedback
  • Target version set to 1.8.7

The Basic theme was added in https://github.com/cuny-academic-commons/cac/commit/318a0bf272f67a4f136e04c2802062d919c85ad3

The gclibrary theme was added in https://github.com/cuny-academic-commons/cac/commit/c0e031351271f9040a4cd95f09f08bd2b46e7129

These will be available as part of the 1.8.7 release, later today.

Can you please let me know the address of the site(s) where the child theme should be made available?

#4 Updated by Stephen Klein about 6 years ago

http://careerplan.commons.gc.cuny.edu/

Will we be able to make an edit on the header.php of the child theme once moved?

Thanks,
Stephen

#5 Updated by Boone Gorges about 6 years ago

  • Status changed from Reporter Feedback to Resolved

The theme is now available to activate on careerplan.commons.gc.cuny.edu.

Will we be able to make an edit on the header.php of the child theme once moved?

If you have any more edits to make to the theme files, they'll need to come through a Redmine ticket. Thanks!

#6 Updated by Stephen Klein about 6 years ago

A few issues:

We tested gclibary theme and then tried to de-activate and turn on our old theme, Customizr and the site is stuck on gclibrary. If there is a bug, just delete gclibrary, because we have a live site and cannot be stuck in development.

We are not able to import via gclibrary=>Themify Settings=>Transfer=>Import a txt file with all the CSS settings. Attached.

We need to edit the header :
<a href="http://careerplan.commons.gc.cuny.edu/"><img src=" http://careerplan.commons.gc.cuny.edu/.....?"><" alt=”CUNY Graduate Center Office of Career Planning and Professional Development" text=" CUNY Graduate Center Office of Career Planning and Professional Development " width="967" height="153" class="logo"/></a>
</div>
Note: not sure of the file name.

I am going on vacation, so can you contact Jenny Furlong and directly?

Thanks,
Stephen

#7 Updated by Jennifer Furlong about 6 years ago

Hi Boone,

Please take a look at this ASAP.

Thanks,

Jenny

#8 Updated by Stephen Klein about 6 years ago

We were able to get it off gclibrary and switched to another theme, but could not switch again or to Customizr.

#9 Updated by Stephen Klein about 6 years ago

Maybe until all Jenny's issues are resolved she can develop on another commons site and then when ready to go live you can switch URLS?

Also, can you restore her site to the way it was at 11 am this morning?

#10 Updated by Stephen Klein about 6 years ago

Additional problem:

Many changes such as switching menus or setting homepage (Settings=>Reading=>Front Page Displays), although changed are not saved.

#11 Updated by Stephen Klein about 6 years ago

Switching themes back seems to be some sort of permissions issue. We can do a live preview of Customizr, but when we attempt to activate/save it returns to the current theme, not the newly chosen.

#12 Updated by Boone Gorges about 6 years ago

I'm looking into why you can't switch to Customizr.

#13 Updated by Stephen Klein about 6 years ago

Thanks and sorry for bombarding you!

#14 Updated by Boone Gorges about 6 years ago

I've switched the site to Customizr. There's an issue (that I haven't figured out yet) that was causing our persistent cache not to be flushed properly when switching themes on the site.

Ray (added as a watcher) - No idea what's up here. Something to do with the 'alloptions' cache. My guess is a race condition during the theme switching process - it's easy to see how it might happen, with all the widget migration, etc.

Jenny, I urge you to set up another Commons site and do a dry-run of the setup/migration. Once you've verified that it's working, we can talk about either switching the URL, or migrating the content to the production site.

#15 Updated by Stephen Klein about 6 years ago

Thanks, Boone. Can you make Themify Basic and gclibrary childtheme available to this new Commons site?

Jenny, send (might have to dropbox it since a php file) Boone your header.php edit, so you can have everything lined up.

#16 Updated by Jennifer Furlong about 6 years ago

Hi Boone,

Thanks for all your help.

I've created another Commons site: careerplantest.commons.gc.cuny.edu to test the GCLibrary theme and build from there. When you have a moment, could you put the GC Library theme in there?

This is the header file for my version of the GC library theme. Tell me if this doesn't look right to you.

<div class="library-logo">
<a href="http://careerplan.commons.gc.cuny.edu/"><img src="https://careerplan.commons.gc.cuny.edu/wp-content/blogs.dir/1372/files/2015/08/careerplanheader.jpg" alt="CUNY Graduate Center Office of Career Planning and Professional Development" text=" CUNY Graduate Center Office of Career Planning and Professional Development " width="967" height="153" class="logo"/></a>
</div>

Thank you again for all your help.

Jenny

#17 Updated by Stephen Klein about 6 years ago

Updated the header.php file:
https://www.dropbox.com/sh/u93l8ncvitdkbn2/AABTda47onVAu_zDLtKb45y5a?dl=0

In:
Dropbox => themify=>basic
as well as the theme itself:
../gclibrary => gclibrary

Because we did not have permission to previously to import, I also placed css (gclibrary_themify_export_2015_08_13 (1).txt) from theme export in Dropbox => themify=>basic
This is for dashboard=>gclibrary=>themify settings=>transfer=>import

Thanks,
Stephen

#18 Updated by Boone Gorges about 6 years ago

The Themify settings importer is written in such a way that it (a) requires that arbitrary file types be uploadable, and (b) the WP installation have full write-access to the filesystem. Neither of these is the case on the Commons. For your site, I manually uploaded and imported the settings. Please verify on careerplantest that the settings are there and are correct. (Note for posterity: see 'themify_import' function in wp-content/mu-plugins/bbg-toolbox.php)

I uploaded your header.php file as a hotfix, but it appears that it's not different from the one that was already there. I see above that you've pasted a bit of markup - the 'library-logo' div, but I don't see any div with this selector in header.php, so I'm not sure whether you mean for me to put it there directly. As a rule, it's easier for our team if you prepare your theme files locally so that they have all the proper markup, and then deliver them to us for a scheduled release (see http://dev.commons.gc.cuny.edu/hosting-partner-handbook/ for details).

#19 Updated by Jennifer Furlong about 6 years ago

Thanks for this update, Boone.

When I look at the careerplantest site, I don't actually see anything. Not sure what is wrong.

Stephen and I are both out tomorrow and all of next week. We'll be regrouping and getting back to this project after August 26.

Jenny

#20 Updated by Boone Gorges about 6 years ago

When I look at the careerplantest site, I don't actually see anything. Not sure what is wrong.

Sorry about this. There was a file permissions error that should now be fixed.

Stephen and I are both out tomorrow and all of next week. We'll be regrouping and getting back to this project after August 26.

Sounds good. Please feel free to report back here, or in a new ticket, when you have more questions.

#21 Updated by Jennifer Furlong about 6 years ago

Hi Boone,

Stephen and I are both back and wanted to reconnect with you about the CareerPlan site.

For the header php file:

<a href="http://careerplan.commons.gc.cuny.edu"><img src="https://careerplan.commons.gc.cuny.edu/wp-content/blogs.dir/1372/files/2015/08/careerplanheader.jpg" width="967" height="153" class="logo" alt="The Graduate Center Office of Career Planning and Professional Development" text="The Graduate Center Office of Career Planning and Professional Development" /></a> ======================================================================
For the custom functions php file:

function insert_fb_in_head() {
global $post;
if ( !is_singular()) //if it is not a post or a page
return;
echo '<meta property="fb:admins" content="17402839"/>';
echo '<meta property="og:title" content="' . get_the_title() . '"/>';
echo '<meta property="og:type" content="article"/>';
echo '<meta property="og:url" content="' . get_permalink() . '"/>';
echo '<meta property="og:site_name" content="The Graduate Office of Career Planning and Professional Development"/>';
echo '<meta property="og:description" content="The Office of Career Planning and Professional Development supports the Graduate Center’s students in reaching their career goals. The office offers individual career counseling to students, including advice on CVs, resumes, and other job search materials; assistance with preparing for interviews; and discussions on career planning strategies."/>';
if(!has_post_thumbnail( $post->ID )) { //the post does not have featured image, use a default image
$default_image="https://careerplan.commons.gc.cuny.edu/wp-content/blogs.dir/1372/files/2015/08/careerplanheader.jpg"; //replace this with a default image on your server or an image in your media library
echo '<meta property="og:image" content="' . $default_image . '"/>';
}
else{
$thumbnail_src = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'medium' );
echo '<meta property="og:image" content="' . esc_attr( $thumbnail_src0 ) . '"/>';
}
echo "
"; ======================================================================================

Is it possible to make these changes in both the careerplantest.commons.gc.cuny.edu and the careerplan.commons.gc.cuny.edu sites? I would like if possible to see how this looks on my test site before trying to go live with this on the actual site.

Also, there is one other thing in custom features that will need to be changed: the Facebook admin ID. I am working on getting one of these.

Thanks!

Jenny

#22 Updated by Matt Gold about 6 years ago

Hi Jenny and Stephen - we don't usually manually update user theme files; instead, we upload custom theme files for members where needed. Rather than submitting lines of code, would it be possible for you to submit the files that need to be uploaded for us?

#23 Updated by Jennifer Furlong about 6 years ago

Hi Boone,

See the header php file attached.

Thanks,

Jenny

#24 Updated by Stephen Klein about 6 years ago

Boone can you take both the header.php and attached custom-functions.php and place in the gclibrary root directory to replace existing versions of those files? Thanks!

#25 Updated by Boone Gorges about 6 years ago

Hi Jenny and Stephen - Thanks for the updated files. I updated them in the repo in https://github.com/cuny-academic-commons/cac/commit/6bf613dfd37c7d5e9c8b9c5b232821eaa0837420. They'll be live on the production site after tomorrow's release 1.8.9 release.

#26 Updated by Jennifer Furlong about 6 years ago

Awesome! Thanks, Boone (and Matt).

Jenny

Also available in: Atom PDF