Project

General

Profile

Bug #447

Widgetize Google Gadjets plugin

Added by scott voth about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress (misc)
Target version:
Start date:
2010-12-08
Due date:
% Done:

0%

Estimated time:

Description

I installed this plugin and found that there is some kind of conflict (maybe with jquery??). When I add the embedded code in the widget, and saved it, the sidebar had parts of the Commons dropdown options from the header on the sidebar rather than content from the gadget. This happened with three gadgets I tried.

The following shows the sidebar of a test blog with the American Memories collection gadget from Library of Congress: http://testprivategroup.commons.gc.cuny.edu/

History

#1 Updated by Matt Gold about 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Boone Gorges
  • Target version set to 1.1.2

#2 Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.1.2 to 1.1.3

#3 Updated by Boone Gorges about 11 years ago

  • Status changed from Assigned to Reporter Feedback

Scott, do you have a local installation of WP you can test on? I'd like to know if this is a problem with the plugin or with the carrington theme - if it's one of those two, then you should be able to tell on a local installation. If it really is a conflict with Commons jquery, I can take it from there.

If you don't have an installation where you can easily test, let me know.

#4 Updated by scott voth about 11 years ago

Hi Boone - I have a blog outside of the Commons and it works fine there. I don't have 3.0 installed locally. I tried this with a couple themes in the Commons and ran into the same issues.

#5 Updated by Boone Gorges about 11 years ago

  • Status changed from Reporter Feedback to Assigned

Thanks, Scott. That's helpful.

#6 Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.1.3 to 1.1.4

#7 Updated by Boone Gorges about 11 years ago

  • Status changed from Assigned to Reporter Feedback

I have just spent a while picking apart the plugin and I found several bugs.

The problem that you were seeing was not a JS conflict, but instead was happening because the iframe created by the widget had an empty src attribute (and in the absence of a valid frame source, it pulled in another copy of the current page). The src could have been empty for a few different reasons: 1) Gadget script was getting double (and triple and quadruple...) encoded on the Dashboard because of a lack on unencoding on the widget control. 2) The method being used to get a valid url src out of the widget code is buggy at best.

I made some changes in https://github.com/castiron/cac/commit/a54fff48555e725e9c68c6c4074b37e3640e1a63 that should address these problems (I hope). I pulled those changes to cdev. Scott, can I ask you to test the plugin on a cdev blog? Thanks.

#8 Updated by scott voth about 11 years ago

Hi Boone - One thing I noticed when I tested this one - in each of the existing blogs that I have in cdev, I could not get to the Widgets option in the dashboard. But when I created a new blog, I had access to the Widgets, and was able to use the plugin. I changed the new blog's theme to Carrington (one of my existing blog used Carrington), just to make sure the widegets were still working, and they worked fine. So I don't know if this is an issue??

#9 Updated by Boone Gorges about 11 years ago

  • Status changed from Reporter Feedback to Resolved

It's likely that the database on cdev is screwed up, so that you are no longer an admin on some of your old cdev blogs. Shouldn't be an issue.

Thanks for testing the plugin mods.

Also available in: Atom PDF