Project

General

Profile

Bug #4729

Links mangled on Commons Profile page

Added by Raffi Khatchadourian almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Commons Profile
Target version:
Start date:
2015-10-02
Due date:
% Done:

0%

Estimated time:

Description

Several of the links on my commons profile page (https://commons.gc.cuny.edu/members/khatchad/?commons-profile=1) are mangled with invalid characters. The result is that the link doesn't go to the correct page. However, the links look fine on my public profile (https://commons.gc.cuny.edu/members/khatchad/). One example is the publications field.

History

#1 Updated by Matt Gold almost 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Boone Gorges

#2 Updated by Boone Gorges almost 4 years ago

  • Category name set to Commons Profile
  • Target version set to 1.8.13

Thanks for the report. It looks like characters are being double-escaped. I'll fix the sanitization for the next release.

#3 Updated by Raffi Khatchadourian almost 4 years ago

Thanks, Boone. Would that also remove the HTML tags? Looks like the Twitter and YouTube ID fields are affected by this. Thanks!

#4 Updated by Boone Gorges almost 4 years ago

  • Status changed from Assigned to Resolved

Would that also remove the HTML tags? Looks like the Twitter and YouTube ID fields are affected by this.

No, not necessarily. It looks like we have an overzealous escape filter. I've replaced it with something that escapes tags only when they're not on our whitelist. This will be fixed in 1.8.13, on the 11th. https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/b41aaf6af95eb7348537801cbf102c4566b42452

Also available in: Atom PDF