Bug #4789
closedIncorrect active date
0%
Description
The group at http://commons.gc.cuny.edu/groups/cstcolloquium/ shows that the group has been active 2 months ago. However, the last blog post was 1 week and 5 days ago. Shouldn't the last active date be the latter?
Updated by Matt Gold over 8 years ago
- Status changed from New to Assigned
- Assignee set to Boone Gorges
Updated by Boone Gorges over 8 years ago
- Category name set to Group Blogs
- Status changed from Assigned to Resolved
- Target version set to 1.8.14
Thanks for opening this ticket, Raffi. The 'last active' data on a group is, for a number of reasons, stored as metadata that is independent of the activity itself. As such, each plugins that creates activity for the group must manually bump the 'last active' metadata when necessary as well. The bp-groupblog plugin that powers the group/blog connection on the Commons was not doing this. I fixed it in https://github.com/boonebgorges/bp-groupblog/commit/79249df5d9ce2b4fdf6dc6be121d05b958c6f112, which was ported to the Commons in https://github.com/cuny-academic-commons/cac/commit/b94a672e220cdb05a17ad251cbb9db5aacda5fd3. This will not fix existing last_active times, but it will be fixed for future groupblog posts.
As a side note, I opted to bump a group's last_active timestamp only when a new post is created, not when a comment is left on a post or a post is edited. The latter could lead to edit floods, and the former seems like it's not quite right semantically, since a non-group-member could conceivably leave a comment on a blog post.
Updated by Raffi Khatchadourian over 8 years ago
Thanks, Boone.
Boone Gorges wrote:
Thanks for opening this ticket, Raffi. The 'last active' data on a group is, for a number of reasons, stored as metadata that is independent of the activity itself. As such, each plugins that creates activity for the group must manually bump the 'last active' metadata when necessary as well. The bp-groupblog plugin that powers the group/blog connection on the Commons was not doing this. I fixed it in https://github.com/boonebgorges/bp-groupblog/commit/79249df5d9ce2b4fdf6dc6be121d05b958c6f112, which was ported to the Commons in https://github.com/cuny-academic-commons/cac/commit/b94a672e220cdb05a17ad251cbb9db5aacda5fd3. This will not fix existing last_active times, but it will be fixed for future groupblog posts.
As a side note, I opted to bump a group's last_active timestamp only when a new post is created, not when a comment is left on a post or a post is edited. The latter could lead to edit floods, and the former seems like it's not quite right semantically, since a non-group-member could conceivably leave a comment on a blog post.