Project

General

Profile

Feature #4932

Allow users to see Files when using wplink feature in BuddyPress Docs

Added by Hannah Aizenman over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority name:
Low
Assignee:
Category name:
BuddyPress Docs
Target version:
Start date:
2015-11-20
Due date:
% Done:

0%

Estimated time:

Description

When searching for content to attach to a doc via link, buddy press file links are never shown, even when the exact name is provided, as seen in the attached screenshot. And, would it be possible to make a file uploaded to buddypress files a child of a doc, as issue #2523 indicates that direct attachment isn't possible.

insert_edit_link.png (15.3 KB) insert_edit_link.png Hannah Aizenman, 2015-11-20 12:40 AM

History

#1 Updated by Hannah Aizenman over 3 years ago

  • Assignee deleted (Boone Gorges)

#2 Updated by Boone Gorges over 3 years ago

  • Subject changed from Allow users to see files in docs to Allow users to see Files when using wplink feature in BuddyPress Docs
  • Assignee set to Boone Gorges
  • Target version set to 1.9

This is a good idea. Let me see how hard it would be.

Just to be clear: by "files" you are talking about items uploaded under the Files tab of a group?

#3 Updated by Hannah Aizenman over 3 years ago

Boone Gorges wrote:

Just to be clear: by "files" you are talking about items uploaded under the Files tab of a group?

Yes and thanks!

#4 Updated by Boone Gorges over 3 years ago

  • Target version changed from 1.9 to 1.9.2

#5 Updated by Boone Gorges over 3 years ago

  • Status changed from New to Resolved

Okey dokey, I've added this in https://github.com/cuny-academic-commons/cac/commit/d6c4725fe0c30d2f48c9c0b1669398d79d4448d4

When editing a Doc in a group, you'll now see that group's Files at the top of the list when selecting from existing content in the Link dialog.

A note for posterity. The wpLink dialog supports a sort of river/infinite-scroll, which works by fetching the next 20 items when the scroll position reaches a certain vertical position. Behind the scenes, this works by passing an incrementing 'offset' to WP_Query. I didn't feel like covering all the possible cases of altered pagination/offset when dealing with group files, so I ignored it: group files are put at the very top of the results, followed immediately by the first 20 post-type results. The only concern here is performance; there may be some delay in cases where a group has many hundreds of Files. But this will only be the case very rarely.

Also available in: Atom PDF