Project

General

Profile

Actions

Bug #5406

closed

Pasted portfolio widget content does not retain spacing

Added by Boone Gorges over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Public Portfolio
Target version:
Start date:
2016-04-04
Due date:
% Done:

0%

Estimated time:
Deployment actions:


Related issues

Related to CUNY Academic Commons - Bug #4405: New portfolio text not savingResolvedBoone Gorges2015-08-08

Actions
Actions #1

Updated by Boone Gorges over 8 years ago

  • Status changed from New to Resolved

This is basically a styling issue. Hallo (the richtext library we're using on the profiles) converts line breaks to <div> elements on paste. Empty div elements don't have any height in non-edit mode, which was causing some spacing to be lost. Fixed in https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/5967b3bf242664a9decdc5ed764903a9dbd6bf4a

Fixing the spacing meant fixing a separate issue that caused Hallo to nest <div> elements when toggling edit mode and pasting lots of stuff. Fixed in https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/2d43a56bd3df1daf0ee74872d1476620ed2e9600 and https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/ea4ea42b7c09eadb5effe141a6c438ba84f30a48

Actions

Also available in: Atom PDF