Project

General

Profile

Actions

Bug #5686

closed

Some content not updating on Prelude16 Site

Added by Alex Hills over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress Themes
Target version:
Start date:
2016-06-10
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi Boone,

I'm noticing the same caching issue with Prelude16 (currently at preludenyc.org) that we experienced with Prelude15 (https://redmine.gc.cuny.edu/issues/4485) and recently with the MESTC site. When I add images to a gallery that is used to cycle through background image on the splash page the changes are not saved when I update the page. Is there any chance you might be able to apply the same hack for MESTC that you did for Prelude15?

Thanks for your help,
Alex


Files

advanced-custom-fields-pro.zip (1.43 MB) advanced-custom-fields-pro.zip Alex Hills, 2016-06-12 12:40 PM
prelude16.zip (2.69 MB) prelude16.zip Alex Hills, 2016-06-12 12:40 PM
prelude16-061716.zip (5.5 MB) prelude16-061716.zip Alex Hills, 2016-06-17 12:38 PM
Actions #1

Updated by Boone Gorges over 6 years ago

  • Status changed from New to Assigned
  • Target version set to Not tracked

Sure. I've made the change. Can you verify?

Actions #2

Updated by Alex Hills over 6 years ago

Thanks, Boone. I still wasn't able to update the image gallery so I created a work around that should solve the problem. It required some updates to the theme so I've attached it here and given it a new name for Prelude 2016. It's also possible that the issue resides in the the Advanced Custom Fields Pro plugin so I've also attached the latest version of this plugin—I know that it can be difficult to automatically update this plugin since it requires a passkey.

I know that it's after the 11th so let me know if there's any way this might get pushed before the 21st. If not, it's not a big deal.

Thanks for your help!
Alex

Actions #3

Updated by Boone Gorges over 6 years ago

  • Status changed from Assigned to Reporter Feedback

Hi Alex,

Thanks for the updating version of the Pro plugin. I've updated it in the repo https://github.com/cuny-academic-commons/cac/commit/4e38be666571e8ef4a3c49b25174d1b7abca6520. I did a quick scan of the diff between the existing version from the Commons and the new one you attached, and it does look like there were some changes to the way cached values are handled. I went ahead and deployed that update to the production site, just in case that update solves your problem.

It appears that the only differences between prelude15 (on the site already) and prelude16 (attached here) are a change to the way favicons are fetched, and a new way of referencing a variable name. Is that right? You mentioned that the change ought to be a workaround for the ACF Pro cache issue, but it's not obvious to me how what I'm seeing will work around that. I also don't know much about ACF Pro, so I'm happy to defer to you. But I don't want to be in a situation where you're guessing what might fix the problem, and we play the deployment back-and-forth game :) If you are reasonably certain your changes will skirt the existing problems, let me know and I'll go ahead and ship it. Otherwise, let's try to do some more targeted debugging to figure out the underlying issue.

Actions #4

Updated by Alex Hills over 6 years ago

Hi Boone,

Thanks for updating the ACF Pro plugin. That seems to have fixed the issues we were seeing with the background image gallery.

You're right, there were only a couple slight differences between the two themes. The favicon change came out of a request from the Segal Center to be able to swap out that favicon manually. The reference of the background_images variable was where I had made a change to try to fix the background images.

ACF has different field types that you can set up for your pages. One is a Gallery field and another in an Image field. The Gallery field allows for the addition of multiple images from your media library which you can then drag and drop for ordering or access their respective fields like their captions, descriptions, etc. The Image field lets you add a single image. Another type of field is called the Repeater field. This lets you add new "rows" of a selected set of fields.

We had been experiencing issues with the Gallery field but no issues with the Image field (the logo image on that splash page had been added using the Image field) so I created Repeater field that allowed the addition of individual Images and Captions again and again.

All that being said, since the update of the ACF Pro plugin seems to have resolved our issues with the Gallery field let's disregard the prelude16 theme at this time. I'll remove the changes that I made for the background images and resubmit the theme with the favicon edit closer to the 21st.

Thanks for your help,
Alex

Actions #5

Updated by Boone Gorges over 6 years ago

  • Target version changed from Not tracked to 1.9.19

Cool - thanks, Alex. I'll leave this ticket open and assign it to the next milestone, so you can resubmit prelude16.

Actions #6

Updated by Alex Hills over 6 years ago

Hi Boone,

I've attached a new archive of the Prelude16 theme. Could this be uploaded on the 21st and made available for the Prelude16 site?

Thanks,
Alex

Actions #7

Updated by Boone Gorges over 6 years ago

  • Category name changed from WordPress (misc) to WordPress Themes

Will do. Thanks, Alex.

Actions #8

Updated by Boone Gorges over 6 years ago

  • Status changed from Reporter Feedback to Resolved

The theme was added to the repo in https://github.com/cuny-academic-commons/cac/commit/535808cf37a033f970b71b49412efb7705a9e862. I just released it to the production site, and made it available for activation on preludenyc16.commons.gc.cuny.edu.

Actions

Also available in: Atom PDF