Bug #5880
closedOption to send invites to group shown in group creation process even when no invitees are selected
0%
Description
I created a group but haven't invited anyone yet; the text on the button shouldn't say "send invites and finish" when no invitees have been selected
Files
Updated by Matt Gold about 8 years ago
Updated by Samantha Raddatz about 8 years ago
Seems like the solution here is not a change in text on the button, but a clearer indication of when a button is "active" and clickable vs not. So, before the user invites people, the 'back to previous step' item is clickable and darker while the 'send invites and finish' button is not clickable and is grayed out/lighter. I'm not sure if we do this elsewhere in the site, but, if we don't it, would be a good standard to set.
(example: https://www.virginamerica.com/ — 'search flights is not available for clicking until you make choices in the dropdown, though the other buttons, like 'grab a seat' clearly are)
Updated by Matt Gold about 8 years ago
Hi Sam,
I think the problem with what you suggest is that this is a required step in a multi-step process. If one wanted to create a group but not invite people to it during the group creation stage process, there would be no way to move forward in that process if the button were deactivated. So, there has to be some kind of null state that allows people not to select anyone to invite but also to move forward in the group creation process
Updated by Boone Gorges about 8 years ago
- Status changed from Assigned to Testing Required
- Target version set to 1.10
Previously: #3503.
The issue here is that invitation is the final step of group creation. As Matt notes, the button has to exist and be clickable, whether or not there are any invitations to be sent, because it's the button that finishes the group creation process. So I think what we want is for the button text to be dynamic: it should say "Finish" when the user has not opted to invite any users, and "Send Invites and Finish" when some invitations are pending. I've done this in https://github.com/cuny-academic-commons/cac/commit/17f11b1dee3458bbe44f31f6f8f05aff6649ec0f. Sam and/or Matt, this is ready to test on the new cdev, if you'd like to see how it feels, and sign off on it.
Updated by Matt Gold about 8 years ago
Sounds like a good solution. Paige, can you please test?
Updated by Matt Gold about 8 years ago
- Assignee changed from Boone Gorges to Paige Dupont
Updated by Paige Dupont about 8 years ago
While I do agree with Sam's suggestion about guiding users towards inviting group members with clickable/non-clickable "send and finish" buttons, I think for our immediate purposes Boone's changes are great. Maybe in the future if the team decides that users cannot create a new group without adding members, we can come back to this idea.
I've run though a group sign up process with Boone's changes and the clarification in language for both states has good functionality in my opinion. When creating a new group with no invitees vs. creating a group with invitees the respective "Finish" vs. "Send and Finish" messages are clear. I think the subtle change works well and I think we should push forward with the update. Thanks for your work on this Boone!
Updated by Boone Gorges about 8 years ago
- Status changed from Testing Required to Resolved
Thanks for the testing and helpful feedback, Paige!