Project

General

Profile

Bug #6075

Suppress useless warnings on sub-blog dashboards

Added by Matt Gold almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress (misc)
Target version:
Start date:
2016-09-23
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone,

I was just looking at the dashboard of the JITP site (jitp.commons.gc.cuny.edu) and noticing how many warnings appear for users when they go to the Dashboard of the site. Since all or most of these warnings are useless to users since they can't upgrade plugins on their own, I think we should consider suppressing them on the grounds of usability (they clutter the page and may confuse users). The only argument I can think of for keeping them is that some power users may actually urge us to act on such notifications (e.g. https://redmine.gc.cuny.edu/issues/6048 )

I've attached a screenshot of the JITP dashboard so that you can see how cluttered it is. I've also cc'ed Paige, Luke, Chris, and Lisa in case they have thoughts.

History

#1 Updated by Luke Waltzer almost 3 years ago

Agree with this in principle, but also think it will be a challenge to identify which warnings are "useless." Some of those pop-ups may contain useful information along with information that the viewer doesn't have ability to act upon.

If all those pop ups were contained within a div we could maybe collapse them by default, but they're not. Is there a relatively easy way to do this?

#2 Updated by Boone Gorges almost 3 years ago

Since all or most of these warnings are useless to users since they can't upgrade plugins on their own,

It appears that most of the ones that fall into the "upgrade plugins" category are, in fact, only visible to users who have the 'install_plugins' capability. On the Commons, only you, I, Ray, and maybe one or two others will ever see these notices.

Each notice is placed independently by a plugin. There's no centralized place where I can hook in and selectively disable them. The only thing I could do would be to disable anything from showing a notice there, but that would also disable things like success/error messages when performing various actions in the Dashboard, so I don't think it's advisable. As such, the only way I can remove individual items is to research how the plugin chooses to add the item, and then taking whatever steps are necessary to prevent the plugin from doing so.

This can be done, but it's time-consuming and fragile - our overrides can be broken by a plugin update. So, if this is a priority, I'd suggest first logging in as a normal site admin; it's probably not a good use of our time to suppress notices visible only to site admins. Then, find the handful of worst offenders - the ugliest, most persistent, notices.

#3 Updated by Matt Gold almost 3 years ago

  • Status changed from Assigned to Rejected

Okay -- thanks. I did not realize that most of these were visible only to super-admins.

#4 Updated by Luke Waltzer almost 3 years ago

Screenshot attached for site admin on JITP. That Easy Rotator notice is ginormous.

I don't fully understand the bottom notice:

"Sorry, but you do not have the correct permissions to install the PhotoSwipe, Simple Google Maps Short Code, WP Instagram Widget, WP-PageNavi, WooCommerce - excelling eCommerce and WooCommerce Product Image Flipper plugins. Contact the administrator of this site for help on getting the plugins installed.
The following required plugin is currently inactive: Advanced Custom Fields."

#5 Updated by Matt Gold almost 3 years ago

  • Status changed from Rejected to Assigned

Ooof. Pulling this back from "rejected" status on the basis of that screenshot.

#6 Updated by Boone Gorges almost 3 years ago

  • Assignee changed from Boone Gorges to Daniel Jones
  • Target version set to Future release

Dan, will you look at the screenshot and figure out how to remove the more annoying of the notices?

#7 Updated by Daniel Jones almost 3 years ago

I've looked into this some, but I'm a little confused: it looks like 3 of those messages can be dismissed by the user, the Twitter one is a legitimate warning that the user should be able to do something about.

On the Viper Video Tags plugin: it looks like we should remove it, or install the replacement plugin. The author has discontinued it: http://www.viper007bond.com/2016/07/04/vipers-video-quicktags-wordpress-plugin-discontinued/

The EasyRotator one is a little weird, but I think it's basically legitimate, too. I imagine it goes away after the user clicks to install the application. If the user doesn't actually want to use the Twitter plugin or EasyRotator, can't they de-activate those plugins?

The notice at the bottom, while dismiss-able, does present an issue though. It looks like there's a few themes on the site that produce that kind of message, using this library: http://tgmpluginactivation.com/ Basically it lets the themes require or recommend a set of plugins. That's a genuine issue with the theme though, that users might want to know: that certain aspects of it won't work right because not all the plugins are installed. Maybe there's a way to make the message more clear? Or another solution?

#8 Updated by Boone Gorges almost 3 years ago

Thanks for this initial research, Dan.

On the Viper Video Tags plugin: it looks like we should remove it, or install the replacement plugin. The author has discontinued it: http://www.viper007bond.com/2016/07/04/vipers-video-quicktags-wordpress-plugin-discontinued/

Yes. Let's remove it and install the replacement. It appears that the replacement maps the legacy shortcode names onto the new, native-to-WP shortcodes. If this is true, we should be able to get away with removing the plugin, installing the new plugin, and network-activating it. Dan, can you verify this? If it's correct, could you open a new ticket and take care of the codebase side of things? Then leave a note in https://github.com/cuny-academic-commons/cac/wiki/Release-ACTION_REQUIRED-list reminding me to network activate the new plugin on release.

The EasyRotator one is a little weird, but I think it's basically legitimate, too. I imagine it goes away after the user clicks to install the application. If the user doesn't actually want to use the Twitter plugin or EasyRotator, can't they de-activate those plugins?

You might be correct about all this, but it's not reasonable that the notice should appear on the main Dashboard page. Easy Rotator has its own top-level menu item. Can you unhook the default admin notice and re-add it, only when viewing the Easy Rotator panel? I think that's good enough for the purposes of this ticket.

The notice at the bottom, while dismiss-able, does present an issue though. It looks like there's a few themes on the site that produce that kind of message, using this library: http://tgmpluginactivation.com/ Basically it lets the themes require or recommend a set of plugins. That's a genuine issue with the theme though, that users might want to know: that certain aspects of it won't work right because not all the plugins are installed. Maybe there's a way to make the message more clear? Or another solution?

Let's do the same thing here. If the theme has its own admin panel, show the notice there only. If it doesn't, let's show it on Appearance and Plugins only. Can you have a look to see if this is possible?

#9 Updated by Daniel Jones almost 3 years ago

Here's my first crack at hiding the EasyRotator admin notices except on its own admin pages: https://github.com/cuny-academic-commons/cac/commit/83f7eb111b698c9b99ccccad43ded5a9fa62e822

I'll take a look at the issue with the theme notices now, and then dig into testing the Viper plugin update/fix.

#10 Updated by Daniel Jones almost 3 years ago

The themes all add their options pages in pretty inconsistent ways, so I don't think there's going to be a good way to tell automatically is the theme has it's own options page or not. I think the best option will be to just show it on Appearance and Plugins for all of them. The other option would be to go through all the themes that have the tgmpluginactivation library individually, see if they have their own admin pages and what they're called, and do the notice-moving on a case-by-case basis.

#11 Updated by Daniel Jones almost 3 years ago

Sorry just realized those changes should be in mu-plugins and not the bp-nelo functions file! Moved it and will put the others here: https://github.com/cuny-academic-commons/cac/commit/95a331fba0e96e78e0bb3c6f51061bc31d5a7528

#12 Updated by Daniel Jones almost 3 years ago

Sorry for all the spamming here, but I've hidden the TGMPA notices except on Appearance and Plugins screens: https://github.com/cuny-academic-commons/cac/commit/14941ff12f18c58783f5b444d10b51324813e26c

#13 Updated by Boone Gorges almost 3 years ago

Excellent! Thanks for your work on this so far.

#14 Updated by Daniel Jones almost 3 years ago

Viper's Video: Yes, it looks like it's just deleting the old plugin and replacing it with the Migrator version, and then leaving that enabled. It looks like it keeps the quicktags intact, although I can't guarantee that all the formatting stuff will still work exactly the same, especially if people were using the defaults, since they're different between Viper's plugin and the Wordpress native ones. Which release should I add it to for the ACTION_REQUIRED? 1.10? I pushed it to the 1.9.x branch: https://github.com/cuny-academic-commons/cac/commit/9272bc6f592590c1af98d05ecd9c0d56b23bb8a0

Last thing - should I handle the Twitter Mentions as Comments notice like we did with EasyRotator? Just making it show up on the plugin's settings page? My only hesitance there is that, because of the way the plugin works, people might not have any other way of knowing that it isn't working, and assume that it is and they just aren't getting any mentions.

#15 Updated by Boone Gorges almost 3 years ago

  • Target version changed from Future release to 1.9.32

Thanks, Dan!

It looks like it keeps the quicktags intact, although I can't guarantee that all the formatting stuff will still work exactly the same, especially if people were using the defaults, since they're different between Viper's plugin and the Wordpress native ones.

Minor style changes shouldn't be a big deal.

Which release should I add it to for the ACTION_REQUIRED? 1.10?

1.9.32, please.

Last thing - should I handle the Twitter Mentions as Comments notice like we did with EasyRotator? Just making it show up on the plugin's settings page? My only hesitance there is that, because of the way the plugin works, people might not have any other way of knowing that it isn't working, and assume that it is and they just aren't getting any mentions.

Good call. This one should probably stay as-is.

If that's it, please feel free to mark this issue resolved. Thank you for your work on it!

#16 Updated by Boone Gorges almost 3 years ago

  • Status changed from Assigned to Resolved

I've made a note in the ACTION_REQUIRED document and will take care of this post-release. Dan, if there are remaining items, let's split into separate tickets. Thanks for your work on this.

#17 Updated by Matt Gold almost 3 years ago

Awesome. Thanks to you both for your work on this -- I think it will make significant improvements in usability

Also available in: Atom PDF