Project

General

Profile

Bug #702

Redmine/Git connection misfires

Added by Boone Gorges about 8 years ago. Updated about 8 years ago.

Status:
Rejected
Priority name:
Low
Assignee:
-
Category name:
Redmine
Target version:
Start date:
2011-04-23
Due date:
% Done:

0%

Estimated time:

Description

Hi André,

Ray, the new member of the dev team, recently started committing fixes to our git repo. The auto ticket-closing seems to be working, but it seems to be doing it in my name, regardless of who committed the fix. See http://redmine.gc.cuny.edu/issues/show/526#note-32 - it was Ray who committed the fix, as can be seen here https://github.com/castiron/cac/commit/ec72020aeb5b62a39c6d66be91b6d54252f026e8

Also, it seems like "See #" shouldn't close a ticket. According to http://redmine.gc.cuny.edu/settings, only 'fixes' and 'closes' should set as resolved.

This is low priority - as long as things are showing up correctly on the Git end (which they are) then our history is intact.

History

#1 Updated by Raymond Hoh about 8 years ago

Just to add a few things.

If you check the auto-close on ticket 526, the commit is different than the one I made.

What Redmine did:
http://redmine.gc.cuny.edu/repositories/diff/cunyac/wp-content/themes/bp-nelo/_inc/css/custom.css?rev=1901a1f0fbc381b717c06f7233868554020be662

What I did:
https://github.com/castiron/cac/commit/ec72020aeb5b62a39c6d66be91b6d54252f026e8


It also looks like the Redmine revision log has stopped synching after April 7:
http://redmine.gc.cuny.edu/repositories/revisions/cunyac

Whereas in Github, it shows the full history:
https://github.com/castiron/cac/commits/master

#2 Updated by local admin about 8 years ago

Boone Gorges wrote:

it was Ray who committed the fix, as can be seen here https://github.com/castiron/cac/commit/ec72020aeb5b62a39c6d66be91b6d54252f026e8

I seem to get a 404 error on this URL. Must I be logged in? Not sure if I have a login there...

Also, it seems like "See #" shouldn't close a ticket. According to http://redmine.gc.cuny.edu/settings, only 'fixes' and 'closes' should set as resolved.

But the commit message does say "Fixes #526". Anything unexpected?

#3 Updated by Raymond Hoh about 8 years ago

André Pitanga wrote:

I seem to get a 404 error on this URL. Must I be logged in? Not sure if I have a login there...

Yeah, I believe you need a Github account and access to the "cac' repository.

But the commit message does say "Fixes #526". Anything unexpected?

That was for a commit made 110 days ago, but the auto-close occurred 3 days ago:
http://redmine.gc.cuny.edu/issues/show/526#note-32

Any idea why?

#4 Updated by Boone Gorges about 8 years ago

Aha, good call, Ray. It must be the case that Redmine doesn't like tickets being reopened and then closed with a different commit. I'll close this ticket and assume that that's the case (which doesn't matter much to me, as it's an edge case).

André, if you want access to the github.com version of the repo, set up and account and pass the username along to me (or Zach or Lucas). Totally optional.

#5 Updated by Boone Gorges about 8 years ago

  • Status changed from Assigned to Rejected

#6 Updated by local admin about 8 years ago

Raymond Hoh wrote:

It also looks like the Redmine revision log has stopped synching after April 7:
http://redmine.gc.cuny.edu/repositories/revisions/cunyac

Whereas in Github, it shows the full history:
https://github.com/castiron/cac/commits/master

Thanks for the heads up, didn't realize this. I've opened a separate ticket for this [http://redmine.gc.cuny.edu/issues/show/703].

#7 Updated by local admin about 8 years ago

Boone Gorges wrote:

André, if you want access to the github.com version of the repo, set up and account and pass the username along to me (or Zach or Lucas). Totally optional.

Boone, I'm gonna have to take you up on getting read access to you github repo in order to troubleshoot this issue thoroughly. Went ahead and created user "apitanga" over there.

Also available in: Atom PDF