Feature #7292
closedLinkedIn link on member page
Added by Raffi Khatchadourian almost 8 years ago. Updated over 7 years ago.
0%
Description
Could there be a form to add a LinkedIn profile URL at the member page (e.g., https://commons.gc.cuny.edu/members/khatchad)? There is already one for twitter and GitHub. Thanks!
Files
bp-social-media-profiles.diff (1.49 KB) bp-social-media-profiles.diff | Boone Gorges, 2017-01-05 11:38 AM |
Updated by Raffi Khatchadourian almost 8 years ago
Interestingly, there is a field for LinkedIn on https://commons.gc.cuny.edu/members/khatchad/profile/edit/group/1/. But, despite populating that field, I don't see a LinkedIn line on the profile.
Updated by Boone Gorges almost 8 years ago
- File bp-social-media-profiles.diff bp-social-media-profiles.diff added
- Status changed from New to Assigned
- Assignee set to Daniel Jones
- Target version set to 1.10.7
Thanks for the report, Raffi.
There was a bug in the way that the Commons's profile fields were being mapped onto the social media sites, such that the lookup was failing when the name of the profile field (such as "LinkedIn Profile Link") wasn't exactly the same as the social network's name ("LinkedIn").
Dan, I think you were the last to touch this. I've attached the patch that I've applied as a hotfix to the production site. It seems to correct the logic for me, but I would like a second look from you.
Updated by Boone Gorges almost 8 years ago
- Target version changed from 1.10.7 to 1.10.8
Updated by Boone Gorges almost 8 years ago
Thanks, Raffi.
Dan, I've still got the hotfix in place. When you get a chance, please have a look to see if my change makes sense.
Updated by Boone Gorges almost 8 years ago
- Target version changed from 1.10.8 to 1.10.9
Updated by Daniel Jones almost 8 years ago
Hey Boone and Raffi - sorry about the long delay here. The change looks right to me. Should I push it to 1.10.x or is it better for you to handle that end, Boone?
Updated by Boone Gorges almost 8 years ago
Cool - thanks, Dan. If you could implement and push, that'd be great. Thanks!
Updated by Boone Gorges almost 8 years ago
- Target version changed from 1.10.9 to 1.10.10
Updated by Boone Gorges almost 8 years ago
- Target version changed from 1.10.10 to 1.10.11
Updated by Boone Gorges almost 8 years ago
- Target version changed from 1.10.11 to 1.10.12
Updated by Boone Gorges over 7 years ago
- Target version changed from 1.10.12 to 1.10.13
Updated by Boone Gorges over 7 years ago
- Target version changed from 1.10.13 to 1.10.14
Updated by Daniel Jones over 7 years ago
Sorry - thought I had already committed this and pushed it. https://github.com/cuny-academic-commons/cac/commit/8c678f97607719e495a0dc3c61aa43436f508ce6