Project

General

Profile

Actions
Copy link

Bug #7769

closed

Commons not allowing registrations from KBCC student email domain

Added by Luke Waltzer about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
Registration
Target version:
1.10.13
Start date:
2017-03-07
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Reported here: https://commons.gc.cuny.edu/groups/cac-faculty-fellows/forum/topic/commons-sign-up-error/

Screenshot attached.

I will create a sign up code for them for use until we can resolve this.

Files

Commons-Error.png (420 KB) Commons-Error.png Luke Waltzer, 2017-03-07 07:35 PM
Actions
Copy link
 #1

Updated by Boone Gorges about 7 years ago

  • Status changed from New to Resolved
  • Assignee set to Boone Gorges
  • Target version set to 1.10.13

At first glance, I couldn't reproduce. But then I started poking around and found a potential problem. If you enter a non-CUNY email address, the non-CUNY signup code box will appear. If you then change your address to a CUNY one (without refreshing the page) the signup code box will disappear. But it's still in the DOM, which means that the signup code plugin tries to validate it. Since the code is incorrect, the validation fails. Based on the nature of this specific error code, I'm pretty sure this is what's happening in the case described here.

There are various ways that this problem might be solved, but I'm taking the easy one and just ensuring that the signup code element is removed from the document if the email address passes the check. https://github.com/cuny-academic-commons/cac/commit/96935442adc065144adfb40c51222e2bc1ccd90a

Because this is causing an immediate problem for new students, I'll deploy as a hotfix. I'm going to tentatively mark as resolved, since it's hard thing to test manually. If we hear more reports, we can reopen and reassess.

Actions
Copy link

Also available in: Atom PDF