Project

General

Profile

Bug #8001

Get rid of one of the 'basic' themes

Added by Boone Gorges almost 2 years ago. Updated almost 2 years ago.

Status:
Rejected
Priority name:
Normal
Assignee:
Category name:
WordPress Themes
Target version:
Start date:
2017-04-20
Due date:
% Done:

0%

Estimated time:

Description

From Ray:

it appears
we have two copies of the Basic theme tracked in the repo with the same
slug:
https://github.com/cuny-academic-commons/cac/blob/master/wp-content/themes/Basic/style.css
https://github.com/cuny-academic-commons/cac/blob/master/wp-content/themes/basic/style.css

One is by Elegant Themes, the other by Themify.

Can we remove one of them?

History

#1 Updated by Boone Gorges almost 2 years ago

  • Category name set to WordPress Themes

I've noticed this problem before, but never tried diagnosing or fixing it.

Before making any changes, we should figure out how this happened - which theme was added first, etc. Then, we see which sites are running 'basic', and which of the Basics is actually being loaded. Ray, can you have a look?

#2 Updated by Raymond Hoh almost 2 years ago

I installed the Multisite Enhancements plugin temporarily to see what sites those basic themes were activated on.

Here are the results:

  • Basic (Elegant Themes) used by site IDs 738, 768, 1129, 1242, 1243, 1279, 1627. Added February 3, 2011.
  • basic (Themify) is not activated, but used as a parent theme for gclibrary. Added
    August 11, 2015.

I would probably recommend renaming the slug from Themify since it only affects one site.

#3 Updated by Boone Gorges almost 2 years ago

Hm. On balance, I'm not sure why we need to do anything, since everything seems to be working fine.

If the folder names bother you, please go ahead and change the Themify one. You'll also need to change the 'Parent' header of the child theme. This'll also require a post-release action, since the 'template' option on the gclibrary site will no longer point to a valid theme. Go ahead and stick this in a milestone if you care enough to attend to these tasks :)

#4 Updated by Raymond Hoh almost 2 years ago

  • Status changed from New to Rejected

On balance, I'm not sure why we need to do anything, since everything seems to be working fine.

Fair enough :)

Go ahead and stick this in a milestone if you care enough to attend to these tasks :)

Closing!

Also available in: Atom PDF