Project

General

Profile

Feature #8053

Theme Requests

Added by Luke Waltzer almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
WordPress Themes
Target version:
Start date:
2017-04-27
Due date:
% Done:

0%

Estimated time:

Description

Would it be possible to add the attached three themes to the 5/1 release? We're exploring using them for a new project we're launching 5/8, and would like to see how they function on the Commons.

Each of these zips were downloaded from the WP theme repo.

author.1.26.zip (1010 KB) author.1.26.zip Luke Waltzer, 2017-04-27 02:45 PM
founder.1.33.zip (1.03 MB) founder.1.33.zip Luke Waltzer, 2017-04-27 02:45 PM
hoffman.1.17.zip (558 KB) hoffman.1.17.zip Luke Waltzer, 2017-04-27 02:45 PM

History

#1 Updated by Boone Gorges almost 2 years ago

  • Status changed from New to Reporter Feedback
  • Target version set to 1.10.18

Sure, this seems fine:

author https://github.com/cuny-academic-commons/cac/commit/adabf825d7bbf73ed959c1002e16a14f0c80d7d0
founder https://github.com/cuny-academic-commons/cac/commit/21b65b33e6fb339668ccefca942324b05246238c
hoffman https://github.com/cuny-academic-commons/cac/commit/6b2d4d90fabddf4c97f1855c409d75093d30f5e9

I installed the latest versions from wordpress.org - I didn't verify that they're the same as the zips that you sent, though I assume it doesn't matter for your purposes.

Can you please let me know where you'd like them enabled after the release? I would prefer not to make them broadly available without a conscientious decision to do so, since people may start using them, at which point we are married to them.

#2 Updated by Luke Waltzer almost 2 years ago

handbook.commons.gc.cuny.edu

Many thanks! I'll let you know if we should remove any of them (or make them a permanent part of the wardrobe closet) in a week or so.

#3 Updated by Boone Gorges almost 2 years ago

Excellent. I'll leave this ticket open so I remember to enable them. (I suppose you could do it as a super admin, but I like to do it myself as part of a mental checklist on release.)

#4 Updated by Boone Gorges almost 2 years ago

  • Target version changed from 1.10.18 to 1.10.19

The release is live, and the themes are enabled for the handbook site.

I'm going to move this ticket to the 1.10.19 milestone. Luke, once you've made a decision about what you'll be going with, could you please let me know? If there's no objection, I'll remove the unused themes.

#5 Updated by Luke Waltzer almost 2 years ago

Thank you Boone.

"Auhtor" is active now, but seems to be blowing up the sitewide footer. Do you mind having a quick look and seeing if there's anything I can add to the custom user style to fix? https://handbook.commons.gc.cuny.edu/

#6 Updated by Boone Gorges almost 2 years ago

It can't really be fixed with CSS. The theme is doing odd things with markup and JS. The following will allow the sidebar to go full-width (though at the expense of part of the body background):

@media all and (min-width: 87.5em) {
  body:before {
    left: 0;
  }
}

The height of the fixed sidebar is set on the 'scroll' event by the theme's JS. There's no way to override this except via JavaScript.

#7 Updated by Matt Gold almost 2 years ago

you can also hide the footer if necessary w/CSS (though that is obviously not preferred)

#8 Updated by Boone Gorges almost 2 years ago

  • Status changed from Reporter Feedback to Resolved

Looks like this was resolved by hiding the footer altogether. I'm going to remove the unused themes and call this ticket resolved.

Also available in: Atom PDF