Feature #8424
closedSelect Forum Text Before Quoting
0%
Description
i'm finding I'm quoting forum posts a lot and then manually recreating the blockquotes so only the segments of the op I want to reference are visible... would be cool if you could select text in a forum post and them only quote that text. would appear along with the header linking author and original post...
Updated by Boone Gorges over 6 years ago
- Assignee set to Raymond Hoh
Yeah, I've done the same thing. Ray, any sense of how hard this would be? (My guess is that it won't be overly hard, but will totally different from the current quote mechanism, since it'll require getting the selection via JS and sending it when clicking Quote. On the bright side, we could potentially move the whole process into the browser this way.)
Updated by Raymond Hoh over 6 years ago
- Status changed from New to Assigned
- Target version set to 1.12
The hard part would be traversing through the DOM to get the post ID and author name for the selection.
Not sure how hard that will be. Going to move this to the next milestone for now. If this is easy, will move back to v1.11.x.
Updated by Boone Gorges over 6 years ago
Oh right. I wonder if we can add `data-` attributes for those things so that no traversing is necessary.
Updated by Raymond Hoh over 6 years ago
Oh right. I wonder if we can add `data-` attributes for those things so that no traversing is necessary.
Not sure if that is possible.
The way I see it is, we will continue to use the existing Quote button.
If there is a selection within the forum post DIV when you click on the Quote button, we'll use the quoted text. If there isn't a selection, we will use the entire post content as it is currently.
Updated by Raymond Hoh over 6 years ago
- Status changed from Assigned to Staged for Production Release
- Target version changed from 1.12 to 1.11.8
Turns out this wasn't as hard as I thought it was going to be.
Added support for selected text for the Quote forum button in https://github.com/cuny-academic-commons/cac/commit/79e24f4c09b6917c648c9c0f364bc2ba61b35d1d.
To use, select the text in a forum post that you want to quote. Next, click on the "Quote" button as usual.
Moving back to 1.11.x.
Updated by Luke Waltzer over 6 years ago
Awesome-- think this will be great addition.
Updated by Boone Gorges over 6 years ago
- Status changed from Staged for Production Release to Resolved