Project

General

Profile

Support #8648

New Prelude 17 Theme

Added by Alex Hills almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Category name:
WordPress Themes
Target version:
Start date:
2017-08-31
Due date:
2017-09-01
% Done:

0%

Estimated time:

Description

Hi Boone,

We have created a new theme for Prelude17 (preludenyc.org). I've attached it here. Is there any chance this could be pushed to the site tomorrow on the 1st? We have a press release going out about the festival on the 6th and we'd love to have the full site up and running.

This theme uses the Advanced Custom Fields plugin for a lot of its content management. In the past, this caused issues with the content caching and not being able to make updates. You had developed a workaround and I was wondering if we could apply that to this site.

Thanks so much!
Alex

prelude17.zip (4.13 MB) prelude17.zip Alex Hills, 2017-08-31 09:05 PM
screenshot.png (2.95 MB) screenshot.png Alex Hills, 2017-09-01 11:03 AM

History

#1 Updated by Boone Gorges almost 2 years ago

  • Target version set to 1.11.11

It shouldn't be a problem to include this in the Sept 1 release. It should go out in the afternoon. I'll update this ticket with details.

Regarding the cache fix, can you look back over #6058 and #6566 and try to piece together whether we actually solved this problem? I'm happy to put the cache exception in place, but I'd prefer not to if things are working properly. Perhaps tomorrow I'll release without the exception, and you can run a quick test to see if things are working right?

#2 Updated by Alex Hills almost 2 years ago

Awesome, thanks so much!

It looks like the caching issues were fixed with an update to the ACF Pro plugin (https://redmine.gc.cuny.edu/issues/5686) so let's try releasing without the exception tomorrow and see how it goes.

Thanks again!
Alex

#3 Updated by Alex Hills almost 2 years ago

I also just realized I didn't include a screenshot.php for the theme in the zip. I've attached one here. Thanks!

#4 Updated by Boone Gorges almost 2 years ago

Theme is added in https://github.com/cuny-academic-commons/cac/commit/9b673d65dabae0c1d76d7487d8e3af93b9c8ec41. I'll make it available on the prelude17 after deployment and update the ticket when it's ready for use.

A small note about the theme: you're registering a copy of jQuery from Google. On the Commons, we always load jQuery on the front end. I know it's an old and clunky version (blame WordPress), but generally it's better to use that version unless there's a pressing reason to use something newer. Thus:

wp_enqueue_script( 'scripts', get_template_directory_uri() . '/js/min/scripts-min.js', array( 'jquery' ), '0.1', true  );

where `array( 'jquery' )` tells WP that your 'scripts' script is dependent on the version of jQuery shipped in core.

It's usually not a big deal either way, and not something you need fix for this theme (unless it causes bugs in production, which you'll know soon!) but it's a best practice for the Commons.

#5 Updated by Boone Gorges almost 2 years ago

  • Status changed from New to Resolved

Enabled. Have fun :)

Also available in: Atom PDF