Project

General

Profile

Bug #9107

Can't add group to non-CUNY sign-up code

Added by Matt Gold over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Non-CUNY sign up codes
Target version:
Start date:
2018-01-23
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone,

I'm trying to add this group -- https://commons.gc.cuny.edu/groups/transpacific-spring2018-gc-nyu/ -- to the "Kandice Chuh class" non-CUNY sign up code, but when I enter transpacific-spring2018-gc-nyu or the full URL, neither works. I don't know if there is supposed to be an autosearch as I begin typing, but basically I am pasting and then hitting update. When the page reloads, there is no group listed

History

#1 Updated by Boone Gorges over 4 years ago

  • Status changed from Assigned to Resolved
  • Target version set to 1.12.7

Thanks for the report. Yes, there is supposed to be autosuggest here, and it's not working due to the fact that the cac-non-cuny-signup plugin isn't enqueuing its JS/CSS assets in a way that's SSL-sensitive. So your browser is blocking them from loading, and the picker is broken.

Fixed in https://github.com/cuny-academic-commons/cac/commit/fbb3441b30f355a4f85b55d2a2e526bae4579c34. A hard refresh after today's release should resolve it for you. (I'll verify.)

#2 Updated by Matt Gold over 4 years ago

great -- thanks!

#3 Updated by Boone Gorges over 4 years ago

Turns out that the bundled autocomplete library was also broken, so I rewrote it to use WP's jquery-ui-autocomplete. https://github.com/cuny-academic-commons/cac/commit/62617ca8c78ada8fc82707565f1168f0a6c8ea33 Appears to be working properly now.

#4 Updated by Matt Gold over 4 years ago

Thanks for your work on this, Boone. I added the code successfully

Also available in: Atom PDF