Project

General

Profile

Bug #9120

Hypothesis Plugin not working on media library PDFs - pt. 2

Added by Laurie Hurson over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2018-01-25
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone,

As you know, the past Hypothesis issue was resolved by clarifying that hypothesis only works on Media Library PDFs if the site visibility is listed as public.

I am having issues with Hypothesis not running on PDFs on a publicly visible site here: https://anasar.commons.gc.cuny.edu/

Specifically, the PDFs are on this page are not working: https://anasar.commons.gc.cuny.edu/mat-216-course-materials/ .

I'm not sure if its because the PDFs are so big? Or because they originally had hyperlinks embedded within them (as anchors tags)? I also noticed that the PDF URLs include a /blogs.dir/ element and I'm not sure if that (or some URL issue) is causing an problem?

Sorry if this is a simple front-end-ish fix that I am just missing.

Thanks in advance for you help.

History

#1 Updated by Boone Gorges over 3 years ago

  • Status changed from New to Resolved
  • Target version set to 1.12.8

Hi Laurie - Thanks for the detailed report.

It appears that the changes in #7997 caused the Hypothesis PDF embedding to break. #7997 changes the way that upload file URLs are generated on public sites, and it does so in a way that isn't compatible with the way that Hypothesis looks for PDFs on the page.

I've written a shim that fixes the issue https://github.com/cuny-academic-commons/cac/commit/247980b64f75925909c552c630ffffe40cc8d512 and deployed to the production site as a hotfix.

#2 Updated by Laurie Hurson over 3 years ago

Hi Boone,

Good to know. Thanks for this fix!

Also available in: Atom PDF