Project

General

Profile

Bug #9177

Social Paper directory not showing any papers

Added by Raymond Hoh almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Social Paper
Target version:
Start date:
2018-02-06
Due date:
% Done:

0%

Estimated time:

Description

The Social Paper directory is not showing any papers.

I discovered this issue when I was debugging #9163.

Not sure when this broke, but I have a fix ready.

History

#1 Updated by Raymond Hoh almost 4 years ago

  • Status changed from New to Staged for Production Release

Fixed in https://github.com/cuny-academic-commons/cac/compare/805c23be59...7bd7b3f969

I actually found two issues:
- No papers displaying on the Papers Directory
- Tab filters ("All Papers", "My Papers") not functioning correctly when the Papers Directory is empty.

For the first issue, my technique for us to load a new template on the Papers Directory requires us to rewind the post loop so we can restart the loop in our bundled custom template. As mentioned in the ticket description, I'm not sure exactly when this broke, but I'm glad I stumbled onto this bug!

Second issue was an oversight during initial implementation.

#2 Updated by Boone Gorges almost 4 years ago

Weird. Thank you for spotting and fixing this!

#3 Updated by Boone Gorges almost 4 years ago

  • Status changed from Staged for Production Release to Resolved

#4 Updated by Raymond Hoh almost 4 years ago

Boone, I forgot to add in the ACTION_REQUIRED list that we need a git submodule update to see the changes on production.

Not sure if you're holding off on this due to the permissions problems, but thought I'd bring it up.

#5 Updated by Boone Gorges almost 4 years ago

I'd added the note to ACTION_REQUIRED myself but then forgot to do any of those items. It's done now. (Sorry.)

#6 Updated by Raymond Hoh almost 4 years ago

Thank you, sir!

Also available in: Atom PDF