Project

General

Profile

Actions

Bug #9603

closed

Manage Invitations in Responsive Mode

Added by Stephen Real almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Onboarding
Target version:
Start date:
2018-04-14
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I tested responsive mode using Safari emulating an iPhone8. It worked, though it certainly wasn't a smooth user experience (the hardest part was navigating the flout hover menus from the BuddyPress link (from my avatar in the top right corner). The modals were pretty good. The one screen that was not responsive was the Manage Invitations. It truncated the right half of the window.


Files

2018-04-16_122725.png (41.3 KB) 2018-04-16_122725.png Raymond Hoh, 2018-04-16 03:27 PM
Actions #1

Updated by Stephen Real almost 6 years ago

The 3rd modal shows up in the middle, rather than the top.

Actions #2

Updated by Stephen Real almost 6 years ago

4th modal shows up in the middle, also.

Actions #3

Updated by Boone Gorges almost 6 years ago

Steve, can you please clarify these comments? What does "shows up in the middle" mean, and what does "3rd" and "4th" modal mean? Screenshots would be helpful.

Actions #4

Updated by Boone Gorges almost 6 years ago

  • Category name set to Onboarding
  • Assignee set to Raymond Hoh
  • Target version set to 1.13

I'm assigning this to Ray based on the note about the Manage Invitations panel. Ray, could you please have a look to see if there are a few media queries you could throw in to make this look OK at some reasonable breakpoints? You can see the (somewhat random) ones that we already use in bp-nelo/_inc/css/custom.css. I know this is not straightforward when using tables. For the modal, I'm using this technique, which was recommended by Chris Stein https://codepen.io/lukepeters/pen/bfFur - it is pretty easy to set up (though it's not true tables) and works pretty nicely.

Steve, if there are issues with the modal, please report them in another ticket, as I'll be handling them instead of Ray. And please provide as many details as you can about what you're seeing.

Actions #5

Updated by Raymond Hoh almost 6 years ago

Just pushed some fixes for this to cdev. (Internal reference - https://github.com/cuny-academic-commons/cac/commit/b50a9d4ce15c1c25fa3655a5c860b200abece418)

I've attached a screenshot:

Actions #6

Updated by Stephen Real almost 6 years ago

  • Status changed from Testing Required to Resolved

Much better. Retested successfully. I am marking this resolved.

Actions

Also available in: Atom PDF