Project

General

Profile

Actions

Bug #9797

closed

Problem with periods and cuny.is links

Added by Raffi Khatchadourian almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
cuny.is
Target version:
Start date:
2018-05-18
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I've found a problem with cuny.is links. Last week, I sent such a link out to some colleagues that was unfortunately at the end of my sentence. As such, my email client included the period in the URL. When they clicked on it, it went to the main commons website rather than the website I had intended. I did some investigative work and it seems that Chrome will autocorrect this problem for URLs ending in a domain (e.g., http://khatchad.setmore.com. still goes to http://khatchad.setmore.com). Then, I tested on bit.ly links. Sure enough, bit.ly also autocorrects this problem, e.g., http://bit.ly/2rloU0F. still goes to http://bit.ly/2rloU0F without the period. I believe that cuny.is links should not consider a period (or perhaps any punctuation ending the link) as part of the identifying URL.

Actions #1

Updated by Matt Gold almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Boone Gorges
Actions #2

Updated by Boone Gorges almost 6 years ago

  • Category name set to cuny.is
  • Status changed from Assigned to Resolved
  • Target version set to 1.13.2

Good catch. I've made a mod so that periods, commas, and hyphens are trimmed. https://github.com/cuny-academic-commons/cac/commit/3237eefe80288a252e4dd883c6279ee6966a6c37

This is live as a hotfix.

Actions

Also available in: Atom PDF