Project

General

Profile

Bug #10356

RBE error

Added by Matt Gold 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Reply By Email
Target version:
Start date:
2018-09-20
Due date:
% Done:

0%

Estimated time:

Description

Hi Ray,

I found it strange that this error message didn't contain info on the message I tried to post (which I sent from the wrong address). Can you please look into this? Screenshot and message original attached

Also, I'm wondering if "no longer a member of the group" is our default text or whether this is showing because I was once a member of the group. If it is just default and gets sent out to anyone who sends a message from a non-subscribed address, I would suggest changing the text to read "because you are not subscribed to this group using the email address [sender email address]"

Best,

Matt

original_msg (14).txt (2.63 KB) original_msg (14).txt Matt Gold, 2018-09-20 11:42 AM
Screen Shot 2018-09-20 at 11.37.48 AM.png (64.6 KB) Screen Shot 2018-09-20 at 11.37.48 AM.png Matt Gold, 2018-09-20 11:44 AM

History

#1 Updated by Boone Gorges 7 months ago

  • Target version set to 1.13.11

#2 Updated by Raymond Hoh 7 months ago

  • Target version changed from 1.13.11 to 1.13.12

Ran out of time to get to this. Will address in the next maintenance release.

#3 Updated by Raymond Hoh 6 months ago

  • Status changed from Assigned to Staged for Production Release

I found it strange that this error message didn't contain info on the message I tried to post (which I sent from the wrong address)

Also, I'm wondering if "no longer a member of the group" is our default text or whether this is showing because I was once a member of the group.

Matt, you received the "no longer a member of the group" email because you mentioned that you used a different email address to compose the email than the email address registered on the Commons and is a member of that group.

Secondly, the email address you used to post the group topic appears to have an account on the Commons (probably is from a secondary test account). Does that sound about right? I don't have enough debug info to find out which user account that is though. If the email address did not exist in the system, you would have received a "user does not exist" email that resembles this:
https://github.com/r-a-y/bp-reply-by-email/blob/master/includes/bp-rbe-functions.php#L1011


However, the "no longer a member of the group" error email you received does lack context. To make things clearer, I've altered the email content to the following:

Group forum topic

Hi there,

Your forum topic with the subject "SUBJECT":

"EMAIL CONTENT" 

Could not be posted because you are no longer a member of the group, "GROUP NAME".  To post a new topic via email to this group, please rejoin the group here:
GROUP PERMALINK URL

We apologize for any inconvenience this may have caused.

Group forum reply

Hi there,

Your forum reply:

"EMAIL REPLY" 

Could not be posted because you are no longer a member of the group, "GROUP NAME".  To comment on the forum thread, please rejoin the group:
GROUP PERMALINK URL

We apologize for any inconvenience this may have caused.

Reference - https://github.com/cuny-academic-commons/cac/commit/c100178ccfd32f2f6f40325beb4d0c3480218df5#diff-8cff9b061cf1317df59a58b00c3533fb

Matt - Let me know if you'd like me to change the email content some more.

#4 Updated by Boone Gorges 6 months ago

  • Status changed from Staged for Production Release to Resolved

About to ship this. Thanks, Ray.

#5 Updated by Matt Gold 6 months ago

Belated thanks for this, Ray. the email looks good

Also available in: Atom PDF