Project

General

Profile

Bug #10381

Group Blog Comment notification doesn't include username

Added by Matt Gold over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2018-09-25
Due date:
% Done:

0%

Estimated time:

Description

Hi Ray -- I see a comment on the blog attached to a group, but the email notification did not list the author's name. Please find screenshots attached and here is a link to the comment itself: https://dhintro18.commons.gc.cuny.edu/2018/09/19/designing-for-difficulty/#comment-66


Related issues

Related to CUNY Academic Commons - Bug #8225: replies to a blog post activity itemResolved2017-06-05

History

#1 Updated by Raymond Hoh over 3 years ago

  • Target version set to 1.13.11

The person commenting does not have a valid user account on the Commons.

When this happens, we should fall back to whatever the commenter's name is from the blog. We currently do not do this.

I'll fix this for the next maintenance release.

#2 Updated by Matt Gold over 3 years ago

Hi Ray -- to clarify, do you mean that she was not logged in at the time she left the comment? Because she does have a CAC account

#3 Updated by Raymond Hoh over 3 years ago

do you mean that she was not logged in at the time she left the comment?

That's correct. She left the comment when logged out and used an email address not attached to an existing Commons user account to post the comment. To be sure, I cross-referenced the email address she used for posting the comment against the Commons user database and couldn't find a match.

#4 Updated by Matt Gold over 3 years ago

Okay -- thanks, Ray!

#5 Updated by Raymond Hoh over 3 years ago

  • Related to Bug #8225: replies to a blog post activity item added

#6 Updated by Raymond Hoh over 3 years ago

  • Status changed from Assigned to Staged for Production Release

This was actually a problem with BP Groupblog not recording the anonymous commenter name during the implementation of #8225. Boone, I've added a pull request to the BP Groupblog repo so you can merge the fix into the main plugin.

I also uncovered a small bug where the post title was not rendering properly in the email subject for groupblog comment emails.

I've fixed both issues here - https://github.com/cuny-academic-commons/cac/compare/94139cd...17fa2cb

#7 Updated by Matt Gold over 3 years ago

Great -- thank you, Ray!

#8 Updated by Boone Gorges over 3 years ago

  • Status changed from Staged for Production Release to Resolved

Looks good, thanks! I'll review the PR on bp-groupblog shortly.

Also available in: Atom PDF